Skip to content

Commit e2d7fe9

Browse files
authored
fix(web): use Array.from() for FileList to fix tsc type errors (langgenius#31398)
1 parent b9f7180 commit e2d7fe9

9 files changed

Lines changed: 10 additions & 10 deletions

File tree

.github/workflows/style.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ jobs:
125125
- name: Web type check
126126
if: steps.changed-files.outputs.any_changed == 'true'
127127
working-directory: ./web
128-
run: pnpm run type-check:tsgo
128+
run: pnpm run type-check
129129

130130
- name: Web dead code check
131131
if: steps.changed-files.outputs.any_changed == 'true'

web/app/components/app/annotation/batch-add-annotation-modal/csv-uploader.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ const CSVUploader: FC<Props> = ({
4848
setDragging(false)
4949
if (!e.dataTransfer)
5050
return
51-
const files = [...e.dataTransfer.files]
51+
const files = Array.from(e.dataTransfer.files)
5252
if (files.length > 1) {
5353
notify({ type: 'error', message: t('stepOne.uploader.validation.count', { ns: 'datasetCreation' }) })
5454
return

web/app/components/app/create-from-dsl-modal/uploader.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ const Uploader: FC<Props> = ({
5858
setDragging(false)
5959
if (!e.dataTransfer)
6060
return
61-
const files = [...e.dataTransfer.files]
61+
const files = Array.from(e.dataTransfer.files)
6262
if (files.length > 1) {
6363
notify({ type: 'error', message: t('stepOne.uploader.validation.count', { ns: 'datasetCreation' }) })
6464
return

web/app/components/apps/hooks/use-dsl-drag-drop.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export const useDSLDragDrop = ({ onDSLFileDropped, containerRef, enabled = true
3636
if (!e.dataTransfer)
3737
return
3838

39-
const files = [...e.dataTransfer.files]
39+
const files = Array.from(e.dataTransfer.files)
4040
if (files.length === 0)
4141
return
4242

web/app/components/datasets/create-from-pipeline/create-options/create-from-dsl-modal/uploader.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ const Uploader: FC<Props> = ({
5454
setDragging(false)
5555
if (!e.dataTransfer)
5656
return
57-
const files = [...e.dataTransfer.files]
57+
const files = Array.from(e.dataTransfer.files)
5858
if (files.length > 1) {
5959
notify({ type: 'error', message: t('stepOne.uploader.validation.count', { ns: 'datasetCreation' }) })
6060
return

web/app/components/datasets/create/file-uploader/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ const FileUploader = ({
278278
onFileListUpdate?.([...fileListRef.current])
279279
}
280280
const fileChangeHandle = useCallback((e: React.ChangeEvent<HTMLInputElement>) => {
281-
let files = [...(e.target.files ?? [])] as File[]
281+
let files = Array.from(e.target.files ?? []) as File[]
282282
files = files.slice(0, fileUploadConfig.batch_count_limit)
283283
initialUpload(files.filter(isValid))
284284
}, [isValid, initialUpload, fileUploadConfig])

web/app/components/datasets/documents/create-from-pipeline/data-source/local-file/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ const LocalFile = ({
230230
if (!e.dataTransfer)
231231
return
232232

233-
let files = [...e.dataTransfer.files] as File[]
233+
let files = Array.from(e.dataTransfer.files) as File[]
234234
if (!supportBatchUpload)
235235
files = files.slice(0, 1)
236236

@@ -251,7 +251,7 @@ const LocalFile = ({
251251
updateFileList([...fileListRef.current])
252252
}
253253
const fileChangeHandle = useCallback((e: React.ChangeEvent<HTMLInputElement>) => {
254-
let files = [...(e.target.files ?? [])] as File[]
254+
let files = Array.from(e.target.files ?? []) as File[]
255255
files = files.slice(0, fileUploadConfig.batch_count_limit)
256256
initialUpload(files.filter(isValid))
257257
}, [isValid, initialUpload, fileUploadConfig.batch_count_limit])

web/app/components/datasets/documents/detail/batch-modal/csv-uploader.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ const CSVUploader: FC<Props> = ({
126126
setDragging(false)
127127
if (!e.dataTransfer)
128128
return
129-
const files = [...e.dataTransfer.files]
129+
const files = Array.from(e.dataTransfer.files)
130130
if (files.length > 1) {
131131
notify({ type: 'error', message: t('stepOne.uploader.validation.count', { ns: 'datasetCreation' }) })
132132
return

web/app/components/plugins/plugin-page/use-uploader.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export const useUploader = ({ onFileChange, containerRef, enabled = true }: Uplo
3636
setDragging(false)
3737
if (!e.dataTransfer)
3838
return
39-
const files = [...e.dataTransfer.files]
39+
const files = Array.from(e.dataTransfer.files)
4040
if (files.length > 0)
4141
onFileChange(files[0])
4242
}

0 commit comments

Comments
 (0)