review comments

rockoder · rockoder · commit ef94015a3696 · 2019-03-10T11:24:33.000+05:30
diff --git a/gson/src/test/java/org/baeldung/gson/advance/GsonAdvanceUnitTest.java b/gson/src/test/java/org/baeldung/gson/advance/GsonAdvanceUnitTest.java
@@ -81,6 +81,7 @@ public void givenPolymorphicList_whenDeserializeWithTypeAdapter_thenCorrect() {
 
         assertEquals(2, outList.size());
         assertTrue(outList.get(0) instanceof Dog);
+        assertTrue(outList.get(1) instanceof Cow);
     }
 
     @Test
@@ -101,7 +102,7 @@ public void givenPolymorphicList_whenDeserializeWithRuntimeTypeAdapter_thenCorre
 
         Type listOfAnimals = new TypeToken<ArrayList<Animal>>() {}.getType();
 
-        RuntimeTypeAdapterFactory<Animal> adapter = RuntimeTypeAdapterFactory.of(Animal.class)
+        RuntimeTypeAdapterFactory<Animal> adapter = RuntimeTypeAdapterFactory.of(Animal.class, "type")
           .registerSubtype(Dog.class)
           .registerSubtype(Cow.class);
 
@@ -111,5 +112,6 @@ public void givenPolymorphicList_whenDeserializeWithRuntimeTypeAdapter_thenCorre
 
         assertEquals(2, outList.size());
         assertTrue(outList.get(0) instanceof Dog);
+        assertTrue(outList.get(1) instanceof Cow);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -81,6 +81,7 @@ public void givenPolymorphicList_whenDeserializeWithTypeAdapter_thenCorrect() {`
`81`	`81`
`82`	`82`	`assertEquals(2, outList.size());`
`83`	`83`	`assertTrue(outList.get(0) instanceof Dog);`
	`84`	`+ assertTrue(outList.get(1) instanceof Cow);`
`84`	`85`	`}`
`85`	`86`
`86`	`87`	`@Test`
`@@ -101,7 +102,7 @@ public void givenPolymorphicList_whenDeserializeWithRuntimeTypeAdapter_thenCorre`
`101`	`102`
`102`	`103`	`Type listOfAnimals = new TypeToken<ArrayList<Animal>>() {}.getType();`
`103`	`104`
`104`		`- RuntimeTypeAdapterFactory<Animal> adapter = RuntimeTypeAdapterFactory.of(Animal.class)`
	`105`	`+ RuntimeTypeAdapterFactory<Animal> adapter = RuntimeTypeAdapterFactory.of(Animal.class, "type")`
`105`	`106`	`.registerSubtype(Dog.class)`
`106`	`107`	`.registerSubtype(Cow.class);`
`107`	`108`
`@@ -111,5 +112,6 @@ public void givenPolymorphicList_whenDeserializeWithRuntimeTypeAdapter_thenCorre`
`111`	`112`
`112`	`113`	`assertEquals(2, outList.size());`
`113`	`114`	`assertTrue(outList.get(0) instanceof Dog);`
	`115`	`+ assertTrue(outList.get(1) instanceof Cow);`
`114`	`116`	`}`
`115`	`117`	`}`