BAEL-4936: Added getColor() method in CircleInterface class as per the review comment

Vikas Ramsingh Rajput · Vikas Ramsingh Rajput · commit 596093f07fdb · 2021-05-30T15:45:46.000+05:30
diff --git a/core-java-modules/core-java-8-2/src/main/java/com/baeldung/interfaceVsAbstractClass/ChidlCircleInterfaceImpl.java b/core-java-modules/core-java-8-2/src/main/java/com/baeldung/interfaceVsAbstractClass/ChidlCircleInterfaceImpl.java
@@ -3,6 +3,7 @@
 public class ChidlCircleInterfaceImpl implements CircleInterface {
     private String color;
 
+    @Override
     public String getColor() {
         return color;
     }
diff --git a/core-java-modules/core-java-8-2/src/main/java/com/baeldung/interfaceVsAbstractClass/CircleInterface.java b/core-java-modules/core-java-8-2/src/main/java/com/baeldung/interfaceVsAbstractClass/CircleInterface.java
@@ -6,8 +6,10 @@
 public interface CircleInterface {
     List<String> allowedColors = Arrays.asList("RED", "GREEN", "BLUE");
 
-    public default boolean isValid(String color) {
-        if (allowedColors.contains(color)) {
+    String getColor();
+    
+    public default boolean isValid() {
+        if (allowedColors.contains(getColor())) {
             return true;
         } else {
             return false;
diff --git a/core-java-modules/core-java-8-2/src/test/java/com/baeldung/interfaceVsAbstractClass/InterfaceVsAbstractClassUnitTest.java b/core-java-modules/core-java-8-2/src/test/java/com/baeldung/interfaceVsAbstractClass/InterfaceVsAbstractClassUnitTest.java
@@ -16,6 +16,6 @@ public void givenAbstractClass_whenValidCircleUsedThenPass() {
     public void givenInterface_whenValidCircleWithoutStateUsedThenPass() {
         ChidlCircleInterfaceImpl redCircleWithoutState = new ChidlCircleInterfaceImpl();
         redCircleWithoutState.setColor("RED");
-        assertTrue(redCircleWithoutState.isValid(redCircleWithoutState.getColor()));
+        assertTrue(redCircleWithoutState.isValid());
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@`
`3`	`3`	`public class ChidlCircleInterfaceImpl implements CircleInterface {`
`4`	`4`	`private String color;`
`5`	`5`
	`6`	`+ @Override`
`6`	`7`	`public String getColor() {`
`7`	`8`	`return color;`
`8`	`9`	`}`
Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,6 @@ public void givenAbstractClass_whenValidCircleUsedThenPass() {`
`16`	`16`	`public void givenInterface_whenValidCircleWithoutStateUsedThenPass() {`
`17`	`17`	`ChidlCircleInterfaceImpl redCircleWithoutState = new ChidlCircleInterfaceImpl();`
`18`	`18`	`redCircleWithoutState.setColor("RED");`
`19`		`- assertTrue(redCircleWithoutState.isValid(redCircleWithoutState.getColor()));`
	`19`	`+ assertTrue(redCircleWithoutState.isValid());`
`20`	`20`	`}`
`21`	`21`	`}`