Changes according to remarks (eugenp#2624)

dimitarsazdovski · pivovarit · commit 02c51358673a · 2017-09-15T22:14:44.000+03:00
diff --git a/geotools/src/main/java/com/baeldung/geotools/ShapeFile.java b/geotools/src/main/java/com/baeldung/geotools/ShapeFile.java
@@ -41,9 +41,7 @@ public static void main(String[] args) throws Exception {
 
         SimpleFeatureType CITY = createFeatureType();
 
-        SimpleFeatureBuilder featureBuilder = new SimpleFeatureBuilder(CITY);
-
-        addLocations(featureBuilder, collection);
+        addLocations(CITY, collection);
 
         File shapeFile = getNewShapeFile();
 
@@ -72,7 +70,7 @@ public static SimpleFeatureType createFeatureType() {
         return CITY;
     }
 
-    public static void addLocations(SimpleFeatureBuilder featureBuilder, DefaultFeatureCollection collection) {
+    public static void addLocations(SimpleFeatureType CITY, DefaultFeatureCollection collection) {
 
         Map<String, List<Double>> locations = new HashMap<>();
 
@@ -113,8 +111,10 @@ public static void addLocations(SimpleFeatureBuilder featureBuilder, DefaultFeat
                 .get(0),
                 location.getValue()
                     .get(1)));
+
+            SimpleFeatureBuilder featureBuilder = new SimpleFeatureBuilder(CITY);
             featureBuilder.add(point);
-            featureBuilder.add(name);
+            featureBuilder.add(location.getKey());
             SimpleFeature feature = featureBuilder.buildFeature(null);
             collection.add(feature);
         }
diff --git a/geotools/src/test/java/com/baeldung/geotools/GeoToolsUnitTest.java b/geotools/src/test/java/com/baeldung/geotools/GeoToolsUnitTest.java
@@ -16,9 +16,7 @@ public void givenFeatureType_whenAddLocations_returnFeatureCollection() {
 
         SimpleFeatureType CITY = ShapeFile.createFeatureType();
 
-        SimpleFeatureBuilder featureBuilder = new SimpleFeatureBuilder(CITY);
-
-        ShapeFile.addLocations(featureBuilder, collection);
+        ShapeFile.addLocations(CITY, collection);
 
         assertNotNull(collection);
 
