If Xcode is configured to not require code signing/provisioning then set...#20
Open
Scraft wants to merge 4 commits into
Open
If Xcode is configured to not require code signing/provisioning then set...#20Scraft wants to merge 4 commits into
Scraft wants to merge 4 commits into
Conversation
…set up workspace not to do either.
Owner
|
I like this, but the latest Xcode update whacked my 7.0 SDK and replaced it with 7.1. Because of that, this code doesn't work. How do you think we should proceed? |
…n, and use the latest one when searching for SDKSettings.plist (I believe there is only ever one directory, but if the code encounters multiple, it'll use the latest).
…workspace_sign_and_provision Conflicts: bin/scripts/ide/xcode.lua
Contributor
Author
|
In commit 94a4d7a I have added a function XcodeHelper_GetLatestIPhoneSDKDirectory which determines the correct SDK directory and then uses this in XcodeHelper_AreEntitlementsRequired and XcodeHelper_IsCodeSigningRequired. This worked for my local tests (I upgraded to 7.1 and had the same issue as you previously). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Xcode 5, by default it insists on code signing/provisioning builds. The problem with this is JamPlus handles the provisioning/code signing, and outputs a ready to deploy .app file, Xcode then goes ahead and resigns and provisions the build, this means next time JamPlus goes to build, it seems the build has been modified and resigns and provisions the build. The output you get is along the lines of:
This annoying behaviour of Xcode can thankfully be disabled, this is done by modifying /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS7.0.sdk/SDKSettings.plist and changing the DefaultProperties:CODE_SIGNING_REQUIRED and DefaultProperties:ENTITLEMENTS_REQUIRED to NO.
This pull request will detect if the above plist change has been made (I'd recommend everyone makes this modification, as it makes the workflow better), if the change is detected the Xcode workspace is generated with no entitlements and signing identify set. In this scenario when you build JamPlus generates a ready to deploy .app, Xcode doesn't alter this app, and subsequent build/deploys do not require JamPlus to sign the build again. If the plist change isn't detected, then existing behaviour will be preserved.