fix(43559): allow renaming in files with no-default-lib enabled (microsoft#43579)

a-tarasyuk · web-flow · commit 482f7813864a · 2021-04-23T16:56:33.000-07:00
diff --git a/src/services/rename.ts b/src/services/rename.ts
@@ -3,15 +3,15 @@ namespace ts.Rename {
     export function getRenameInfo(program: Program, sourceFile: SourceFile, position: number, options?: RenameInfoOptions): RenameInfo {
         const node = getAdjustedRenameLocation(getTouchingPropertyName(sourceFile, position));
         if (nodeIsEligibleForRename(node)) {
-            const renameInfo = getRenameInfoForNode(node, program.getTypeChecker(), sourceFile, declaration => program.isSourceFileDefaultLibrary(declaration.getSourceFile()), options);
+            const renameInfo = getRenameInfoForNode(node, program.getTypeChecker(), sourceFile, program, options);
             if (renameInfo) {
                 return renameInfo;
             }
         }
         return getRenameInfoError(Diagnostics.You_cannot_rename_this_element);
     }
 
-    function getRenameInfoForNode(node: Node, typeChecker: TypeChecker, sourceFile: SourceFile, isDefinedInLibraryFile: (declaration: Node) => boolean, options?: RenameInfoOptions): RenameInfo | undefined {
+    function getRenameInfoForNode(node: Node, typeChecker: TypeChecker, sourceFile: SourceFile, program: Program, options?: RenameInfoOptions): RenameInfo | undefined {
         const symbol = typeChecker.getSymbolAtLocation(node);
         if (!symbol) {
             if (isStringLiteralLike(node)) {
@@ -33,7 +33,7 @@ namespace ts.Rename {
         if (!declarations || declarations.length === 0) return;
 
         // Disallow rename for elements that are defined in the standard TypeScript library.
-        if (declarations.some(isDefinedInLibraryFile)) {
+        if (declarations.some(declaration => isDefinedInLibraryFile(program, declaration))) {
             return getRenameInfoError(Diagnostics.You_cannot_rename_elements_that_are_defined_in_the_standard_TypeScript_library);
         }
 
@@ -55,6 +55,11 @@ namespace ts.Rename {
         return getRenameInfoSuccess(displayName, fullDisplayName, kind, SymbolDisplay.getSymbolModifiers(typeChecker,symbol), node, sourceFile);
     }
 
+    function isDefinedInLibraryFile(program: Program, declaration: Node) {
+        const sourceFile = declaration.getSourceFile();
+        return program.isSourceFileDefaultLibrary(sourceFile) && fileExtensionIs(sourceFile.fileName, Extension.Dts);
+    }
+
     function getRenameInfoForModule(node: StringLiteralLike, sourceFile: SourceFile, moduleSymbol: Symbol): RenameInfo | undefined {
         if (!isExternalModuleNameRelative(node.text)) {
             return getRenameInfoError(Diagnostics.You_cannot_rename_a_module_via_a_global_import);
diff --git a/tests/cases/fourslash/renameNoDefaultLib.ts b/tests/cases/fourslash/renameNoDefaultLib.ts
@@ -0,0 +1,12 @@
+/// <reference path="fourslash.ts" />
+
+// @checkJs: true
+// @allowJs: true
+
+// @Filename: /foo.js
+//// // @ts-check
+//// /// <reference no-default-lib="true" />
+//// const [|/**/foo|] = 1;
+
+goTo.marker("");
+verify.renameInfoSucceeded("foo")
