Update on RssReader implementation

vogella · vogella · commit 96a9e8f2a2fd · 2018-09-25T20:19:12.000+02:00
diff --git a/RssReader/app/build.gradle b/RssReader/app/build.gradle
@@ -2,7 +2,7 @@ apply plugin: 'com.android.application'
 
 android {
     compileSdkVersion 25
-    buildToolsVersion "25.0.3"
+    buildToolsVersion '27.0.3'
     defaultConfig {
         applicationId "com.example.android.rssreader"
         minSdkVersion 25
@@ -20,15 +20,15 @@ android {
 }
 
 dependencies {
-    compile fileTree(include: ['*.jar'], dir: 'libs')
-    androidTestCompile('com.android.support.test.espresso:espresso-core:2.2.2', {
+    implementation fileTree(include: ['*.jar'], dir: 'libs')
+    androidTestImplementation('com.android.support.test.espresso:espresso-core:2.2.2', {
         exclude group: 'com.android.support', module: 'support-annotations'
     })
-    compile "com.android.support:recyclerview-v7:25.3.1"
-    testCompile 'junit:junit:4.12'
-    compile project(':com.example.android.rssfeedlibrary')
-    compile 'com.github.bumptech.glide:glide:3.8.0'
-    compile 'com.android.support:support-v4:25.3.1'
-    compile 'com.google.code.gson:gson:2.8.1'
-    compile 'com.squareup:otto:1.3.8'
+    implementation "com.android.support:recyclerview-v7:25.4.0"
+    testImplementation 'junit:junit:4.12'
+    implementation project(':com.example.android.rssfeedlibrary')
+    implementation 'com.github.bumptech.glide:glide:4.2.0'
+    implementation 'com.android.support:support-v4:25.4.0'
+    implementation 'com.google.code.gson:gson:2.8.1'
+    implementation 'com.squareup:otto:1.3.8'
 }
diff --git a/RssReader/app/src/main/java/com/example/android/rssreader/MyListFragment.java b/RssReader/app/src/main/java/com/example/android/rssreader/MyListFragment.java
@@ -46,6 +46,12 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle sa
         return view;
     }
 
+    @Override
+    public void onDestroyView() {
+        RssApplication.bus.unregister(this);
+        super.onDestroyView();
+    }
+
     public interface OnItemSelectedListener {
         void onRssItemSelected(String link);
     }
diff --git a/RssReader/build.gradle b/RssReader/build.gradle
@@ -3,9 +3,10 @@
 buildscript {
     repositories {
         jcenter()
+        google()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:2.3.3'
+        classpath 'com.android.tools.build:gradle:3.1.4'
 
         // NOTE: Do not place your application dependencies here; they belong
         // in the individual module build.gradle files
@@ -15,6 +16,7 @@ buildscript {
 allprojects {
     repositories {
         jcenter()
+        google()
     }
 }
 
diff --git a/RssReader/com.example.android.rssfeedlibrary/build.gradle b/RssReader/com.example.android.rssfeedlibrary/build.gradle
@@ -2,7 +2,6 @@ apply plugin: 'com.android.library'
 
 android {
     compileSdkVersion 25
-    buildToolsVersion "25.0.3"
 
     defaultConfig {
         minSdkVersion 25
@@ -22,10 +21,10 @@ android {
 }
 
 dependencies {
-    compile fileTree(dir: 'libs', include: ['*.jar'])
-    androidTestCompile('com.android.support.test.espresso:espresso-core:2.2.2', {
+    implementation fileTree(dir: 'libs', include: ['*.jar'])
+    androidTestImplementation('com.android.support.test.espresso:espresso-core:2.2.2', {
         exclude group: 'com.android.support', module: 'support-annotations'
     })
-    testCompile 'junit:junit:4.12'
+    testImplementation 'junit:junit:4.12'
 
 }
diff --git a/RssReader/gradle/wrapper/gradle-wrapper.properties b/RssReader/gradle/wrapper/gradle-wrapper.properties
@@ -1,6 +1,6 @@
-#Tue Jun 27 16:14:35 CEST 2017
+#Mon Sep 24 22:20:27 CEST 2018
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-3.3-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-4.4-all.zip

Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,12 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle sa`
`46`	`46`	`return view;`
`47`	`47`	`}`
`48`	`48`
	`49`	`+ @Override`
	`50`	`+ public void onDestroyView() {`
	`51`	`+ RssApplication.bus.unregister(this);`
	`52`	`+ super.onDestroyView();`
	`53`	`+ }`
	`54`	`+`
`49`	`55`	`public interface OnItemSelectedListener {`
`50`	`56`	`void onRssItemSelected(String link);`
`51`	`57`	`}`
Original file line number	Diff line number	Diff line change
`@@ -3,9 +3,10 @@`
`3`	`3`	`buildscript {`
`4`	`4`	`repositories {`
`5`	`5`	`jcenter()`
	`6`	`+ google()`
`6`	`7`	`}`
`7`	`8`	`dependencies {`
`8`		`- classpath 'com.android.tools.build:gradle:2.3.3'`
	`9`	`+ classpath 'com.android.tools.build:gradle:3.1.4'`
`9`	`10`
`10`	`11`	`// NOTE: Do not place your application dependencies here; they belong`
`11`	`12`	`// in the individual module build.gradle files`
`@@ -15,6 +16,7 @@ buildscript {`
`15`	`16`	`allprojects {`
`16`	`17`	`repositories {`
`17`	`18`	`jcenter()`
	`19`	`+ google()`
`18`	`20`	`}`
`19`	`21`	`}`
`20`	`22`