Fixed cppcheck-opensource#7755 (false positive: member variable is not initialized in the constructor)

githubharald · danmar · commit 0de47f709eb7 · 2016-10-26T10:39:53.000+02:00
diff --git a/lib/checkclass.cpp b/lib/checkclass.cpp
@@ -633,7 +633,7 @@ void CheckClass::initializeVarList(const Function &func, std::list<const Functio
             if (ftok->str() == "::")
                 ftok = ftok->next();
             int offsetToMember = 4;
-            if (ftok->tokAt(ftok->strAt(2) == "&"))
+            if (ftok->strAt(2) == "&")
                 ++offsetToMember;
             assignVar(ftok->tokAt(offsetToMember)->varId(), scope, usage);
             ftok = ftok->linkAt(1);
diff --git a/test/testconstructors.cpp b/test/testconstructors.cpp
@@ -2849,6 +2849,16 @@ class TestConstructors : public TestFixture {
               "  return foobar.foo.f + foobar.bar.b;\n"
               "}");
         ASSERT_EQUALS("[test.cpp:4]: (warning) Member variable 'FooBar::bar' is not initialized in the constructor.\n", errout.str());
+
+        // #7755
+        check("struct A {\n"
+              "  A() {\n"
+              "    memset(this->data, 0, 42);\n"
+              "  }\n"
+              "  char data[42];\n"
+              "};");
+        ASSERT_EQUALS("", errout.str());
+
     }
 
     void privateCtor1() {
