Use valueOf factory method instead of constructor

federicobond · federicobond · commit ac91c59a3fbf · 2014-10-28T14:30:09.000-03:00
diff --git a/core/src/processing/core/PShapeSVG.java b/core/src/processing/core/PShapeSVG.java
@@ -1811,7 +1811,7 @@ public Font(PShapeSVG parent, XML properties) {
               namedGlyphs.put(fg.name, fg);
             }
             if (fg.unicode != 0) {
-              unicodeGlyphs.put(new Character(fg.unicode), fg);
+              unicodeGlyphs.put(Character.valueOf(fg.unicode), fg);
             }
           }
           glyphs[glyphCount++] = fg;
@@ -1845,7 +1845,7 @@ public void drawString(PGraphics g, String str, float x, float y, float size) {
       char[] c = str.toCharArray();
       for (int i = 0; i < c.length; i++) {
         // call draw on each char (pulling it w/ the unicode table)
-        FontGlyph fg = unicodeGlyphs.get(new Character(c[i]));
+        FontGlyph fg = unicodeGlyphs.get(Character.valueOf(c[i]));
         if (fg != null) {
           fg.draw(g);
           // add horizAdvX/unitsPerEm to the x coordinate along the way
@@ -1863,7 +1863,7 @@ public void drawChar(PGraphics g, char c, float x, float y, float size) {
       float s =  size / face.unitsPerEm;
       g.translate(x, y);
       g.scale(s, -s);
-      FontGlyph fg = unicodeGlyphs.get(new Character(c));
+      FontGlyph fg = unicodeGlyphs.get(Character.valueOf(c));
       if (fg != null) g.shape(fg);
       g.popMatrix();
     }
@@ -1874,7 +1874,7 @@ public float textWidth(String str, float size) {
       char[] c = str.toCharArray();
       for (int i = 0; i < c.length; i++) {
         // call draw on each char (pulling it w/ the unicode table)
-        FontGlyph fg = unicodeGlyphs.get(new Character(c[i]));
+        FontGlyph fg = unicodeGlyphs.get(Character.valueOf(c[i]));
         if (fg != null) {
           w += (float) fg.horizAdvX / face.unitsPerEm;
         }
diff --git a/core/src/processing/data/JSONObject.java b/core/src/processing/data/JSONObject.java
@@ -1492,7 +1492,7 @@ static protected Object stringToValue(String string) {
             return d;
           }
         } else {
-          Long myLong = new Long(string);
+          Long myLong = Long.valueOf(string);
           if (myLong.longValue() == myLong.intValue()) {
             return Integer.valueOf(myLong.intValue());
           } else {

Original file line number	Diff line number	Diff line change
`@@ -1492,7 +1492,7 @@ static protected Object stringToValue(String string) {`
`1492`	`1492`	`return d;`
`1493`	`1493`	`}`
`1494`	`1494`	`} else {`
`1495`		`- Long myLong = new Long(string);`
	`1495`	`+ Long myLong = Long.valueOf(string);`
`1496`	`1496`	`if (myLong.longValue() == myLong.intValue()) {`
`1497`	`1497`	`return Integer.valueOf(myLong.intValue());`
`1498`	`1498`	`} else {`