Merged
Conversation
For use cases where only the final subcommand in the sequence needs to be run (e.g. `git remote add` just runs the add subcommand of remote), it would be useful to identify that subcommand directly. Since that pointer is already helpfully stored in the parser, simply exposing it via a method worked nicely.
integrii
requested changes
Apr 23, 2022
Owner
integrii
left a comment
integrii
left a comment
There was a problem hiding this comment.
This is awesome, but I would like to change Terminal to Trailing here if we could. I submitted suggestions to edit your change to Trailing terminology - you just have to hit accept on it.
Co-authored-by: Eric Greer <[email protected]>
integrii
approved these changes
Apr 23, 2022
Owner
integrii
left a comment
integrii
left a comment
There was a problem hiding this comment.
Thanks for taking the time to come back and contribute! I like it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For use cases where only the final subcommand in the sequence needs to be run
(e.g.
git remote addjust runs theaddsubcommand ofremote), it would beuseful to identify that subcommand directly. Since that pointer is already
helpfully stored in the parser, simply exposing it via a method worked nicely.