Drop support for macos and add so files directly to repo#1
Open
youngcho22 wants to merge 8 commits intoib-bazelfrom
Open
Drop support for macos and add so files directly to repo#1youngcho22 wants to merge 8 commits intoib-bazelfrom
youngcho22 wants to merge 8 commits intoib-bazelfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: What this PR does is HORRIBLE! It's only a tentative solution to "somewhat" hermetically build python-magic which requires
libmagic.Background
python-magic requires
libmagicto be installed on the host machine. It was challenging to hermetically buildlibmagicusing bazel (due to various reasons such as properly setting LD_LIBRARY_PATH), so as a tentative solution to bundlelibamgicinto python-magic, I directly added sh files into the workspace.Also, the support for macos users is dropped, as they can install libmagic separately on their system. The reason for the drop is because python-magic does a static look-up for finding libmagic, which isn't compatible with Bazel, hence, dropped.
Test
On Linux,