Add PermalinkCleanup module to remove /blog prefix on main site #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soean
reviewed
Oct 20, 2025
Co-authored-by: Sören Wünsch <[email protected]> Signed-off-by: Oleksandr Zhyian <[email protected]>
lloc
requested changes
Oct 21, 2025
Member
There was a problem hiding this comment.
I like the PR, thanks for sending it. :-)
I have just one doubt, since we declare compatibility with PHP 7.4 🙈. Wouldn't it be better to have a polyfill for str_starts_with?
We should probably introduce a PHP matrix in our test workflow (in another PR maybe).
Contributor
Author
|
Thanks, for the feedback. Since this module runs within WordPress context, |
Member
|
@zhyian I guess it does. :-) Also, we declared that we want to have at least WordPress 6.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
In WordPress multisite installations, the main site often has
/blogprepended to post permalinks.What is the new behavior (if this is a feature change)?
Added new module to automatically remove
/blogprefix from the main site's permalink structure in WordPress multisite installations.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
Closes #24