Add support for prioritized asset #70
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
Preambule
This feature is not to be confused with:
async,defer, etc.This must be considered all asset location/attributes equal.
Problem
WordPress provides no straightforward (besides hook priority) way to control asset output order. Further more, this library abstract enqueue related actions where hook priority isn't reachable.
When multiple scripts or styles are enqueued, their order in the HTML depends on registration order, which can be hard to manage when scattered across plugins, themes, etc.
Example:
Although adding different priorities to
AssetManager::ACTION_SETUPwill work, it's not very convenient and will eventually fail or become unmaintainable when registering multiple assets with different priorities within the same hook.Having priority defined per asset feels way more natural and maintainable approach.
What is the new behavior (if this is a feature change)?
This PR adds a priority property to assets (lower = earlier, WP style). The
AssetCollectionnow sorts assets by priority before returning them, ensuring predictable output order regardless of registration timing.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No. I created a
PrioritizedAssetinterface to avoid changing theAssetinterface. So this feature is completely backward compatible.Other information
You can take a look at Capo.js for ideal head order as a reason for this feature.