Skip to content

Conversation

@widoz
Copy link
Member

@widoz widoz commented Nov 11, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Do not mark the main Asset interface as internal

What is the current behavior? (You can also link to an open issue here)

Asset interface is hidden from the external after a minor release

What is the new behavior (if this is a feature change)?

Revert the changes from minor to fix the breaking change

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No, it resolves it.

Other information

@widoz widoz requested a review from Chrico November 11, 2025 20:02
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.22%. Comparing base (c842144) to head (ae94013).

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #67   +/-   ##
=========================================
  Coverage     87.22%   87.22%           
  Complexity      334      334           
=========================================
  Files            27       27           
  Lines           955      955           
=========================================
  Hits            833      833           
  Misses          122      122           
Flag Coverage Δ
unittests 87.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@widoz widoz merged commit ed92efd into master Nov 12, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants