Use Kernel#loop for infinite loops

alexdowad · alexdowad · commit c3e9ace8eba4 · 2020-04-12T15:07:00.000+02:00
diff --git a/lib/immutable/list.rb b/lib/immutable/list.rb
@@ -268,7 +268,7 @@ def select(&block)
       return enum_for(:select) unless block_given?
       LazyList.new do
         list = self
-        while true
+        loop do
           break list if list.empty?
           break Cons.new(list.head, list.tail.select(&block)) if yield(list.head)
           list = list.tail
@@ -895,7 +895,7 @@ def indices(object = Undefined, i = 0, &block)
       return EmptyList if empty?
       LazyList.new do
         node = self
-        while true
+        loop do
           break Cons.new(i, node.tail.indices(Undefined, i + 1, &block)) if yield(node.head)
           node = node.tail
           break EmptyList if node.empty?
@@ -1346,7 +1346,7 @@ def cached_size?
     MUTEX = Mutex.new
 
     def realize
-      while true
+      loop do
         # try to "claim" the right to run the block which realizes target
         if @atomic.compare_and_set(0,1) # full memory barrier here
           begin
@@ -1455,7 +1455,7 @@ def realize
       mutex = @mutex
       mutex && mutex.synchronize do
         return if @head != Undefined # another thread got ahead of us
-        while true
+        loop do
           if !@buffer.empty?
             @head = @buffer.shift
             @tail = Partitioned.new(@partitioner, @buffer, @mutex)
@@ -1516,7 +1516,7 @@ def realize
         mutex = @mutex
         mutex && mutex.synchronize do
           return if @head != Undefined # another thread got ahead of us
-          while true
+          loop do
             if !@buffer.empty?
               @head = @buffer.shift
               @tail = Left.new(@splitter, @buffer, @mutex)
diff --git a/lib/immutable/sorted_set.rb b/lib/immutable/sorted_set.rb
@@ -948,7 +948,7 @@ def eql?(other)
       return false if not instance_of?(other.class)
       return false if size != other.size
       a, b = self.to_enum, other.to_enum
-      while true
+      loop do
         return false if !a.next.eql?(b.next)
       end
     rescue StopIteration
diff --git a/lib/immutable/vector.rb b/lib/immutable/vector.rb
@@ -1084,13 +1084,13 @@ def product(*vectors)
       end
 
       if block_given?
-        while true
+        loop do
           yield build_array[]
           return self if bump_counters[]
         end
       else
         result = []
-        while true
+        loop do
           result << build_array[]
           return result if bump_counters[]
         end
