Skip to content
This repository was archived by the owner on Jan 17, 2025. It is now read-only.

Disable trace for docker login.#277

Merged
Luke-Roy-IBM merged 1 commit into
ibm-functions:masterfrom
falkzoll:updateRuntime
Dec 13, 2023
Merged

Disable trace for docker login.#277
Luke-Roy-IBM merged 1 commit into
ibm-functions:masterfrom
falkzoll:updateRuntime

Conversation

@falkzoll

Copy link
Copy Markdown
Contributor

Run the docker login in a subshell with disabled trace to avoid having credentials in the logs when trace is on (set -x).

@Luke-Roy-IBM Luke-Roy-IBM left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Luke-Roy-IBM Luke-Roy-IBM merged commit 87a97f6 into ibm-functions:master Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants