Skip to content

feat: sub-path exports#1522

Draft
AdrianGonz97 wants to merge 6 commits intomainfrom
feat/package-export-map
Draft

feat: sub-path exports#1522
AdrianGonz97 wants to merge 6 commits intomainfrom
feat/package-export-map

Conversation

@AdrianGonz97
Copy link
Collaborator

@AdrianGonz97 AdrianGonz97 commented May 28, 2025

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented May 28, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: d03dd8b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@AdrianGonz97 AdrianGonz97 marked this pull request as draft May 28, 2025 17:09
@github-actions
Copy link
Contributor

github-actions bot commented May 28, 2025 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
bits-ui ✅ Ready (View Log) Visit Preview d03dd8b

AdrianGonz97
AdrianGonz97 commented May 28, 2025
View reviewed changes
packages/bits-ui/src/lib/bits/scroll-area/types.ts
Without<BitsPrimitiveDivAttributes, ScrollAreaCornerPropsWithoutHTML>;

export type _ScrollbarStubProps = Omit<ScrollAreaScrollbarProps, "orientation" | "ref" | "id"> & {
export type ScrollbarStubProps = Omit<ScrollAreaScrollbarProps, "orientation" | "ref" | "id"> & {
Copy link
Collaborator Author

@AdrianGonz97 AdrianGonz97 May 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noting this here since it seems like it was mistakenly named with a _ prefix

AdrianGonz97
AdrianGonz97 commented May 28, 2025
View reviewed changes
packages/bits-ui/src/lib/bits/calendar/types.ts
Comment on lines +231 to +237
type _CalendarSingleRootPropsWithoutHTML = CalendarBaseRootPropsWithoutHTML &
CalendarSingleRootPropsWithoutHTML;

export type CalendarSingleRootProps = _CalendarSingleRootPropsWithoutHTML &
Without<BitsPrimitiveDivAttributes, _CalendarSingleRootPropsWithoutHTML>;

export type _CalendarMultipleRootPropsWithoutHTML = CalendarBaseRootPropsWithoutHTML &
type _CalendarMultipleRootPropsWithoutHTML = CalendarBaseRootPropsWithoutHTML &
Copy link
Collaborator Author

@AdrianGonz97 AdrianGonz97 May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these two don't look like they were meant to be exposed

AdrianGonz97
AdrianGonz97 commented May 28, 2025
View reviewed changes
packages/bits-ui/src/lib/bits/select/types.ts
export type SelectRootProps = SelectRootPropsWithoutHTML;

export type _SharedSelectContentProps = {
type _SharedSelectContentProps = {
Copy link
Collaborator Author

@AdrianGonz97 AdrianGonz97 May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also looks like it wasn't meant to be exposed

@colinlienard
Copy link

colinlienard commented Dec 11, 2025

Hey @AdrianGonz97 I’m interested in sub-path exports, are you planning to continue this pr?

@colinlienard colinlienard mentioned this pull request Dec 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AdrianGonz97 @colinlienard