Skip to content

[tests] Pipeline test refactor#14113

Open
sayakpaul wants to merge 8 commits into
mainfrom
pipeline-test-refactor
Open

[tests] Pipeline test refactor#14113
sayakpaul wants to merge 8 commits into
mainfrom
pipeline-test-refactor

Conversation

@sayakpaul

@sayakpaul sayakpaul commented Jul 3, 2026

Copy link
Copy Markdown
Member

Notes

  • The PR doesn't have LoRA-related tests refactored yet. That will be a big change, and I want to do it in a different PR to keep the reviewing scope manageable.
  • I haven't yet added a generate_pipeline_level_tests.py script. Will be done in subsequent PRs once other mixins, such as LoRA, are added.
  • There were a lot of overlaps between the pipeline-level and model-level quantization tests. So, I have removed redundancy as much as possible by keeping only the pipeline-level quantization tests that genuinely require pipeline-level specs.
  • I have used pytest features as much as possible. This is particularly reflected in the use of custom fixtures. For example, base_pipe_output. This way, we don't have to compute it for every test that requires it.

I have only refactored the Flux pipeline tests to use the new mixin, as we do in other PRs. Will open subsequent PRs for other pipelines and involve the community.

@github-actions github-actions Bot added tests size/L PR with diff > 200 LOC labels Jul 3, 2026
@sayakpaul

Copy link
Copy Markdown
Member Author

/diffusers-bot pytest tests/pipelines/flux/test_pipeline_flux.py::TestFluxPipeline::test_float16_inference

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

pytest tests/pipelines/flux/test_pipeline_flux.py::TestFluxPipeline::test_float16_inference failed on GPU — view logs.

@@ -1,9 +1,15 @@
import contextlib

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes here are migrating to pytest.



@is_staging_test
class PipelinePushToHubTester(unittest.TestCase):

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to tests/pipelines/test_pipeline_utils.py

@sayakpaul sayakpaul marked this pull request as ready for review July 6, 2026 03:07
@sayakpaul sayakpaul requested review from DN6, dg845 and yiyixuxu July 6, 2026 03:07
@sayakpaul

Copy link
Copy Markdown
Member Author

All the failing tests are quite unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L PR with diff > 200 LOC tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant