Handle server initiated global requests #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #472 +/- ##
============================================
- Coverage 55.92% 55.84% -0.08%
- Complexity 1215 1216 +1
============================================
Files 192 192
Lines 7859 7870 +11
Branches 714 715 +1
============================================
Hits 4395 4395
- Misses 3112 3123 +11
Partials 352 352
Continue to review full report at Codecov.
|
Owner
|
Thanks @pepijnve! |
Contributor
Author
|
Context for this change is that I kept seeing |
Owner
|
Thanks for the background info! |
Repository owner
deleted a comment
Nov 26, 2018
Repository owner
deleted a comment
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 4254 section 4 states that either side of the connection
may send global requests at any time and that the receiver
MUST respond appropriately.
This PR replaces the default logic of responding with 'UNIMPLEMENTED'
with the correct 'MSG_REQUEST_FAILURE' if 'wantReply' is set.