Skip to content

Fix issue 209. #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hierynomus merged 1 commit into from
Aug 18, 2015
Merged

Fix issue 209. #210

hierynomus merged 1 commit into from
Aug 18, 2015

Conversation

@dkocher
Copy link
Contributor

@dkocher dkocher commented Aug 17, 2015

Please review.

@dkocher dkocher mentioned this pull request Aug 17, 2015
Closed
@hierynomus
Copy link
Owner

hierynomus commented Aug 17, 2015

Hi David, this qualifies for a small testcase :) On first sight the fix looks good, but I'd rather see some tests

hierynomus added a commit that referenced this pull request Aug 18, 2015
@hierynomus
Merge pull request #210 from iterate-ch/issue-209
28a11b0 
Fix issue 209.
@hierynomus hierynomus merged commit 28a11b0 into hierynomus:master Aug 18, 2015
@dkocher dkocher deleted the issue-209 branch August 18, 2015 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dkocher @hierynomus