Skip to content

Commit 95736d3

Browse files
committed
Corrected singular/plural disagreements in test function names
In a wild fit of pedantry, I have changed test function names in test_sensei for both Python 2 and 3 to hvae correct verb conjugation ("is" for a single success, "are" for multiple successes).
1 parent ade4b6e commit 95736d3

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

python2/runner/runner_tests/test_sensei.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -234,28 +234,28 @@ def test_that_if_there_are_0_successes_it_will_say_the_first_zen_of_python_koans
234234
m = re.search("Beautiful is better than ugly", words)
235235
self.assertTrue(m and m.group(0))
236236

237-
def test_that_if_there_is_1_successes_it_will_say_the_second_zen_of_python_koans(self):
237+
def test_that_if_there_is_1_success_it_will_say_the_second_zen_of_python_koans(self):
238238
self.sensei.pass_count = 1
239239
self.sensei.failures = Mock()
240240
words = self.sensei.say_something_zenlike()
241241
m = re.search("Explicit is better than implicit", words)
242242
self.assertTrue(m and m.group(0))
243243

244-
def test_that_if_there_is_10_successes_it_will_say_the_sixth_zen_of_python_koans(self):
244+
def test_that_if_there_are_10_successes_it_will_say_the_sixth_zen_of_python_koans(self):
245245
self.sensei.pass_count = 10
246246
self.sensei.failures = Mock()
247247
words = self.sensei.say_something_zenlike()
248248
m = re.search("Sparse is better than dense", words)
249249
self.assertTrue(m and m.group(0))
250250

251-
def test_that_if_there_is_36_successes_it_will_say_the_final_zen_of_python_koans(self):
251+
def test_that_if_there_are_36_successes_it_will_say_the_final_zen_of_python_koans(self):
252252
self.sensei.failures = Mock()
253253
self.sensei.pass_count = 36
254254
words = self.sensei.say_something_zenlike()
255255
m = re.search("Namespaces are one honking great idea", words)
256256
self.assertTrue(m and m.group(0))
257257

258-
def test_that_if_there_is_37_successes_it_will_say_the_first_zen_of_python_koans_again(self):
258+
def test_that_if_there_are_37_successes_it_will_say_the_first_zen_of_python_koans_again(self):
259259
self.sensei.pass_count = 37
260260
self.sensei.failures = Mock()
261261
words = self.sensei.say_something_zenlike()

python3/runner/runner_tests/test_sensei.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -213,28 +213,28 @@ def test_that_if_there_are_0_successes_it_will_say_the_first_zen_of_python_koans
213213
m = re.search("Beautiful is better than ugly", words)
214214
self.assertTrue(m and m.group(0))
215215

216-
def test_that_if_there_is_1_successes_it_will_say_the_second_zen_of_python_koans(self):
216+
def test_that_if_there_is_1_success_it_will_say_the_second_zen_of_python_koans(self):
217217
self.sensei.pass_count = 1
218218
self.sensei.failures = Mock()
219219
words = self.sensei.say_something_zenlike()
220220
m = re.search("Explicit is better than implicit", words)
221221
self.assertTrue(m and m.group(0))
222222

223-
def test_that_if_there_is_10_successes_it_will_say_the_sixth_zen_of_python_koans(self):
223+
def test_that_if_there_are_10_successes_it_will_say_the_sixth_zen_of_python_koans(self):
224224
self.sensei.pass_count = 10
225225
self.sensei.failures = Mock()
226226
words = self.sensei.say_something_zenlike()
227227
m = re.search("Sparse is better than dense", words)
228228
self.assertTrue(m and m.group(0))
229229

230-
def test_that_if_there_is_36_successes_it_will_say_the_final_zen_of_python_koans(self):
230+
def test_that_if_there_are_36_successes_it_will_say_the_final_zen_of_python_koans(self):
231231
self.sensei.pass_count = 36
232232
self.sensei.failures = Mock()
233233
words = self.sensei.say_something_zenlike()
234234
m = re.search("Namespaces are one honking great idea", words)
235235
self.assertTrue(m and m.group(0))
236236

237-
def test_that_if_there_is_37_successes_it_will_say_the_first_zen_of_python_koans_again(self):
237+
def test_that_if_there_are_37_successes_it_will_say_the_first_zen_of_python_koans_again(self):
238238
self.sensei.pass_count = 37
239239
self.sensei.failures = Mock()
240240
words = self.sensei.say_something_zenlike()

0 commit comments

Comments
 (0)