Skip to content

Commit ba2e716

Browse files
miguelrinconjlipps
authored andcommitted
Updates tests for node: capabilities, url and npm args
* Updated appium version, fixed node's url compatibility issue * Updated README with working npm config * Remove comments
1 parent e23f03a commit ba2e716

3 files changed

Lines changed: 11 additions & 11 deletions

File tree

sample-code/examples/node/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@ npm install
1515
Then when running the tests, add your Sauce Labs credentials as npm config parameters, example :
1616

1717
```
18-
npm run ios-simple appium-sample-code:sauce=1 appium-sample-code:sauce_username=<SAUCE_USERNAME> appium-sample-code:sauce_access_key=<SAUCE_ACCESS_KEY>
18+
npm run ios-simple --appium-sample-code:sauce=1 --appium-sample-code:username=<SAUCE_USERNAME> --appium-sample-code:key=<SAUCE_ACCESS_KEY>
19+
1920
```
2021

2122
Or set the config parameters directly in package.json :

sample-code/examples/node/helpers/appium-servers.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,5 @@ exports.local = {
77
exports.sauce = {
88
host: 'ondemand.saucelabs.com',
99
port: 80,
10-
username: process.env.npm_package_config_username,
11-
password: process.env.npm_package_config_key
10+
auth: process.env.npm_package_config_username + ":" + process.env.npm_package_config_key
1211
};

sample-code/examples/node/helpers/caps.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.ios92 = {
22
browserName: '',
3-
'appium-version': '1.3',
3+
appiumVersion: '1.5.3',
44
platformName: 'iOS',
55
platformVersion: '9.2',
66
deviceName: 'iPhone 5s',
@@ -9,7 +9,7 @@ exports.ios92 = {
99

1010
exports.ios81 = {
1111
browserName: '',
12-
'appium-version': '1.3',
12+
appiumVersion: '1.5.3',
1313
platformName: 'iOS',
1414
platformVersion: '8.1',
1515
deviceName: 'iPhone Simulator',
@@ -18,27 +18,27 @@ exports.ios81 = {
1818

1919
exports.android18 = {
2020
browserName: '',
21-
'appium-version': '1.3',
21+
appiumVersion: '1.5.3',
2222
platformName: 'Android',
23-
platformVersion: '4.3',
23+
platformVersion: '5.1',
2424
deviceName: 'Android Emulator',
2525
app: undefined // will be set later
2626
};
2727

2828
exports.android19 = {
2929
browserName: '',
30-
'appium-version': '1.3',
30+
appiumVersion: '1.5.3',
3131
platformName: 'Android',
32-
platformVersion: '4.4.2',
32+
platformVersion: '5.1',
3333
deviceName: 'Android Emulator',
3434
app: undefined // will be set later
3535
};
3636

3737
exports.selendroid16 = {
3838
browserName: '',
39-
'appium-version': '1.3',
39+
appiumVersion: '1.5.3',
4040
platformName: 'Android',
41-
platformVersion: '4.1',
41+
platformVersion: '5.1',
4242
automationName: 'selendroid',
4343
deviceName: 'Android Emulator',
4444
app: undefined // will be set later

0 commit comments

Comments
 (0)