Skip to content

Add new step Signature that will format function signatures#350

Draft
EncodePanda wants to merge 11 commits intohaskell:mainfrom
EncodePanda:signature-format
Draft

Add new step Signature that will format function signatures#350
EncodePanda wants to merge 11 commits intohaskell:mainfrom
EncodePanda:signature-format

Conversation

@EncodePanda
Copy link
Contributor

@EncodePanda EncodePanda commented Feb 3, 2021 •
edited
Loading

Adds a new step to format function signatures

Example:

    input = unlines
      [ "module Herp where"
      , ""
      , "fooBar :: a -> b -> a"
      , "fooBar v _ = v"
      ]
    expected = unlines
      [ "module Herp where"
      , ""
      , "fooBar ::"
      , "     a"
      , "  -> b"
      , "  -> a"
      , "fooBar v _ = v"
      ]

For more examples please see the test suite.

This step is heavily
inspired by https://github.com/input-output-hk/ouroboros-network/blob/bf8579cc2ff2a7bc4ba23150eff659cfd1c6ccca/ouroboros-consensus/docs/StyleGuide.md

@EncodePanda EncodePanda added the wip Work In Progress label Feb 3, 2021
@EncodePanda EncodePanda marked this pull request as draft February 15, 2021 19:20
EncodePanda added 11 commits April 9, 2021 21:55
@EncodePanda
Add new step Signature that will format function signatures
9b36847 
The step is a NOP still but additional tests were already created
specifing how we anticipate the step to behave. This step is heavily
inspired by https://github.com/input-output-hk/ouroboros-network/blob/bf8579cc2ff2a7bc4ba23150eff659cfd1c6ccca/ouroboros-consensus/docs/StyleGuide.md
@EncodePanda
Modify Signature to look top level func signatures and prepare for fo…
b30c944 
…rmatting
@EncodePanda
Add noop change function
d66228d
@EncodePanda
Add getEndColumnUnsafe for a given Located element
0bd9851
@EncodePanda
Implement test case 'wrap signature if it does not fit max column len…
53f6d6c 
…gth'
@EncodePanda
Extract printDecl to separate toplevel function
0497835
@EncodePanda
Extract helper printing functions
d9ccfdb
@EncodePanda
Simplify formatSignatureDecl
ce99839
@EncodePanda
Simplify access to SignatureDecl inside printDecl
f331870
@EncodePanda
Extract printRemainingLine function
63e3bbf
@EncodePanda
Implement "how it behaves when there is a list of constraints"
41ca2df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

wip Work In Progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@EncodePanda