Change the strict option in bindingRowsWithHeaders example to true to match the description#12179
Open
adrianszymanski89 wants to merge 2 commits intodevelopfrom
Open
Change the strict option in bindingRowsWithHeaders example to true to match the description#12179adrianszymanski89 wants to merge 2 commits intodevelopfrom
strict option in bindingRowsWithHeaders example to true to match the description#12179adrianszymanski89 wants to merge 2 commits intodevelopfrom
Conversation
adrianszymanski89
added
the
Docs: Content
commit: |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Example now uses wrong binding mode
- I restored
bindRowsWithHeadersto'strict'in the JavaScript, Angular, and React row-header examples so row insert/remove behavior matches the intended strict binding mode.
- I restored
Or push these changes by commenting:
@cursor push 39a17cbd83
Preview (39a17cbd83)
diff --git a/docs/content/guides/rows/row-header/angular/example1.ts b/docs/content/guides/rows/row-header/angular/example1.ts
--- a/docs/content/guides/rows/row-header/angular/example1.ts
+++ b/docs/content/guides/rows/row-header/angular/example1.ts
@@ -21,7 +21,7 @@
height: 'auto',
contextMenu: true,
manualRowMove: true,
- bindRowsWithHeaders: true,
+ bindRowsWithHeaders: 'strict',
autoWrapRow: true,
autoWrapCol: true,
};
diff --git a/docs/content/guides/rows/row-header/javascript/example1.js b/docs/content/guides/rows/row-header/javascript/example1.js
--- a/docs/content/guides/rows/row-header/javascript/example1.js
+++ b/docs/content/guides/rows/row-header/javascript/example1.js
@@ -26,7 +26,7 @@
height: 'auto',
contextMenu: true,
manualRowMove: true,
- bindRowsWithHeaders: true,
+ bindRowsWithHeaders: 'strict',
autoWrapRow: true,
autoWrapCol: true,
licenseKey: 'non-commercial-and-evaluation',
diff --git a/docs/content/guides/rows/row-header/react/example1.tsx b/docs/content/guides/rows/row-header/react/example1.tsx
--- a/docs/content/guides/rows/row-header/react/example1.tsx
+++ b/docs/content/guides/rows/row-header/react/example1.tsx
@@ -27,7 +27,7 @@
height="auto"
contextMenu={true}
manualRowMove={true}
- bindRowsWithHeaders={true}
+ bindRowsWithHeaders={'strict'}
autoWrapRow={true}
autoWrapCol={true}
licenseKey="non-commercial-and-evaluation"This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
Contributor
|
✅ Preview documentation is is available now |
AMBudnik
approved these changes
Mar 20, 2026
Contributor
AMBudnik
left a comment
AMBudnik
left a comment
There was a problem hiding this comment.
From the content perspective I approve the changes, but it seems that the API itself is not doing what it suppose to do 🤔
@Wojciech-Swiderski can you help? I've created a demo https://jsfiddle.net/6zvq5phm/ it should highlight the changes once we move row 0 below row 2 but there's no difference in the Ui and in the index mapper response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Change the
strictoption inbindingRowsWithHeadersexample totrueto match the description and add the list of possible options to the guide.How has this been tested?
Types of changes
Related issue(s):
Affected project(s):
handsontable@handsontable/angular-wrapper@handsontable/react-wrapper@handsontable/vue3Checklist:
[skip changelog]
Note
Low Risk
Low risk documentation-only change that updates example configuration values; no runtime/library code is modified.
Overview
Updates the row header guide examples (JS/TS, React, Angular) to set
bindRowsWithHeaderstotrueinstead of'strict', matching the guide’s “Basic example” description.Expands the guide text to explicitly document the supported
bindRowsWithHeadersvalues (true,strict,loose) and what each means.Written by Cursor Bugbot for commit 46287d6. This will update automatically on new commits. Configure here.