Skip to content

setSourceDataAtCell() would incorrectly update a parent row instead of the intended nested child row when the nestedRows option was enabled#12143

Open
adrianspdev wants to merge 2 commits intodevelopfrom
cursor/issue-10657-aa11
Open

setSourceDataAtCell() would incorrectly update a parent row instead of the intended nested child row when the nestedRows option was enabled#12143
adrianspdev wants to merge 2 commits intodevelopfrom
cursor/issue-10657-aa11

Conversation

@adrianspdev
Copy link
Contributor

Context

This change addresses an issue where setSourceDataAtCell() would incorrectly update a parent row instead of the intended nested child row when the nestedRows option was enabled. The DataSource.setAtCell() method now correctly writes to the row object resolved by the modifyRowData hook, ensuring accurate updates for nested data structures.

How has this been tested?

  • Unit tests: A new unit test was added to dataSource.unit.js to verify that DataSource.setAtCell() correctly writes through hook-resolved row objects, ensuring proper data layer updates for nested-like data.
  • E2E tests: An E2E regression test was added to setSourceDataAtCell.spec.js to confirm that Core.setSourceDataAtCell with nestedRows: true correctly updates child data while leaving sibling parents unchanged.
  • Linting: All modified files passed lint checks.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. The setSourceDataAtCell doesn't works on children #10657

Affected project(s):

  • handsontable
  • @handsontable/angular-wrapper
  • @handsontable/react-wrapper
  • @handsontable/vue3

Checklist:

Open in Web Open in Cursor 

@cursor
Copy link

cursor bot commented Mar 12, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 12, 2026

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8934b1e:

Sandbox Source
handsontable-pr-javascript-demo Configuration
handsontable-ts-demo Configuration
handsontable-pr-react-demo Configuration

@qunabu qunabu changed the title Issue 10657 setSourceDataAtCell() would incorrectly update a parent row instead of the intended nested child row when the nestedRows option was enabled Mar 12, 2026
@qunabu qunabu marked this pull request as ready for review March 13, 2026 09:10
@Wojciech-Swiderski
Copy link
Contributor

@qunabu qunabu requested review from budnix and jansiegel March 19, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants