setSourceDataAtCell() would incorrectly update a parent row instead of the intended nested child row when the nestedRows option was enabled#12143
Open
adrianspdev wants to merge 2 commits intodevelopfrom
Open
Conversation
Co-authored-by: Adrian Dusinkiewicz <[email protected]>
|
Cursor Agent can help with this pull request. Just |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8934b1e:
|
Co-authored-by: Adrian Dusinkiewicz <[email protected]>
setSourceDataAtCell() would incorrectly update a parent row instead of the intended nested child row when the nestedRows option was enabled
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This change addresses an issue where
setSourceDataAtCell()would incorrectly update a parent row instead of the intended nested child row when thenestedRowsoption was enabled. TheDataSource.setAtCell()method now correctly writes to the row object resolved by themodifyRowDatahook, ensuring accurate updates for nested data structures.How has this been tested?
dataSource.unit.jsto verify thatDataSource.setAtCell()correctly writes through hook-resolved row objects, ensuring proper data layer updates for nested-like data.setSourceDataAtCell.spec.jsto confirm thatCore.setSourceDataAtCellwithnestedRows: truecorrectly updates child data while leaving sibling parents unchanged.Types of changes
Related issue(s):
setSourceDataAtCelldoesn't works on children #10657Affected project(s):
handsontable@handsontable/angular-wrapper@handsontable/react-wrapper@handsontable/vue3Checklist: