Added tests for prepared metadata id and conditional statements

beltran · beltran · commit 08777cb8c37a · 2017-11-07T16:09:59.000-05:00
diff --git a/tests/integration/standard/test_prepared_statements.py b/tests/integration/standard/test_prepared_statements.py
@@ -447,6 +447,7 @@ def test_prepared_id_is_update(self):
         """
         prepared_statement = self.session.prepare("SELECT * from {} WHERE a = ?".format(self.table_name))
         id_before = prepared_statement.result_metadata_id
+        self.assertEqual(len(prepared_statement.result_metadata), 3)
 
         self.session.execute("ALTER TABLE {} ADD c int".format(self.table_name))
         bound_statement = prepared_statement.bind((1, ))
@@ -455,6 +456,7 @@ def test_prepared_id_is_update(self):
         id_after = prepared_statement.result_metadata_id
 
         self.assertNotEqual(id_before, id_after)
+        self.assertEqual(len(prepared_statement.result_metadata), 4)
 
     def test_prepared_id_is_updated_across_pages(self):
         """
@@ -468,6 +470,7 @@ def test_prepared_id_is_updated_across_pages(self):
         """
         prepared_statement = self.session.prepare("SELECT * from {}".format(self.table_name))
         id_before = prepared_statement.result_metadata_id
+        self.assertEqual(len(prepared_statement.result_metadata), 3)
 
         prepared_statement.fetch_size = 2
         result = self.session.execute(prepared_statement.bind((None)))
@@ -483,6 +486,7 @@ def test_prepared_id_is_updated_across_pages(self):
 
         self.assertEqual(result_set, expected_result_set)
         self.assertNotEqual(id_before, id_after)
+        self.assertEqual(len(prepared_statement.result_metadata), 4)
 
     def test_prepare_id_is_updated_across_session(self):
         """
@@ -499,6 +503,7 @@ def test_prepare_id_is_updated_across_session(self):
 
         stm = "SELECT * from {} WHERE a = ?".format(self.table_name)
         one_prepared_stm = one_session.prepare(stm)
+        self.assertEqual(len(one_prepared_stm.result_metadata), 3)
 
         one_id_before = one_prepared_stm.result_metadata_id
 
@@ -507,6 +512,7 @@ def test_prepare_id_is_updated_across_session(self):
 
         one_id_after = one_prepared_stm.result_metadata_id
         self.assertNotEqual(one_id_before, one_id_after)
+        self.assertEqual(len(one_prepared_stm.result_metadata), 4)
 
     def test_not_reprepare_invalid_statements(self):
         """
@@ -521,3 +527,59 @@ def test_not_reprepare_invalid_statements(self):
         self.session.execute("ALTER TABLE {} DROP d".format(self.table_name))
         with self.assertRaises(InvalidRequest):
             self.session.execute(prepared_statement.bind((1, )))
+
+    def test_id_is_not_updated_conditional_v4(self):
+        """
+        Test that verifies that the result_metadata and the
+        result_metadata_id are udpated correctly in conditional statements
+        in protocol V4
+
+        @since 3.13
+        @jira_ticket PYTHON-847
+        """
+        cluster = Cluster(protocol_version=ProtocolVersion.V4)
+        session = cluster.connect()
+        self.addCleanup(cluster.shutdown)
+        self._test_updated_conditional(session, 9)
+
+    def test_id_is_not_updated_conditional_v5(self):
+        """
+        Test that verifies that the result_metadata and the
+        result_metadata_id are udpated correctly in conditional statements
+        in protocol V5
+
+        @since 3.13
+        @jira_ticket PYTHON-847
+        """
+        cluster = Cluster(protocol_version=ProtocolVersion.V5)
+        session = cluster.connect()
+        self.addCleanup(cluster.shutdown)
+        self._test_updated_conditional(session, 10)
+
+    def _test_updated_conditional(self, session, value):
+        prepared_statement = session.prepare("INSERT INTO {}(a, b, d) VALUES "
+                                                  "(?, ? , ?) IF NOT EXISTS".format(self.table_name))
+        first_id = prepared_statement.result_metadata_id
+        self.assertEqual(prepared_statement.result_metadata, [])
+
+        # Sucessfull conditional update
+        result = session.execute(prepared_statement, (value, value, value))
+        self.assertEqual(result[0], (True, ))
+        second_id = prepared_statement.result_metadata_id
+        self.assertEqual(first_id, second_id)
+
+        # Failed conditional update
+        result = session.execute(prepared_statement, (value, value, value))
+        self.assertEqual(result[0], (False, value, value, value))
+        third_id = prepared_statement.result_metadata_id
+        self.assertEqual(first_id, third_id)
+        self.assertEqual(prepared_statement.result_metadata, [])
+
+        session.execute("ALTER TABLE {} ADD c int".format(self.table_name))
+
+        # Failed conditional update
+        result = session.execute(prepared_statement, (value, value, value))
+        self.assertEqual(result[0], (False, value, value, None, value))
+        fourth_id = prepared_statement.result_metadata_id
+        self.assertEqual(first_id, fourth_id)
+        self.assertEqual(prepared_statement.result_metadata, [])
