Add pageName and filters as optional parameters to IEmebedConfiguration to match parameters from ILoadConfiguration

Matt Mazzola · Matt Mazzola · commit f351cc8212d3 · 2016-08-03T15:59:39.000-07:00
diff --git a/src/embed.ts b/src/embed.ts
@@ -21,13 +21,17 @@ declare global {
     }
 }
 
+// TODO: Re-use ILoadConfiguration interface to prevent duplicating properties.
+// Current issue is that they are optional when embedding since they can be specificed as attributes but they are required when loading.
 export interface IEmbedConfiguration {
     type?: string;
     id?: string;
     uniqueId?: string;
     embedUrl?: string;
     accessToken?: string;
     settings?: models.ISettings;
+    pageName?: string;
+    filters?: (models.IBasicFilter | models.IAdvancedFilter)[];
 }
 
 export interface IInternalEmbedConfiguration extends models.ILoadConfiguration {

Original file line number	Diff line number	Diff line change
`@@ -21,13 +21,17 @@ declare global {`
`21`	`21`	`}`
`22`	`22`	`}`
`23`	`23`
	`24`	`+// TODO: Re-use ILoadConfiguration interface to prevent duplicating properties.`
	`25`	`+// Current issue is that they are optional when embedding since they can be specificed as attributes but they are required when loading.`
`24`	`26`	`export interface IEmbedConfiguration {`
`25`	`27`	`type?: string;`
`26`	`28`	`id?: string;`
`27`	`29`	`uniqueId?: string;`
`28`	`30`	`embedUrl?: string;`
`29`	`31`	`accessToken?: string;`
`30`	`32`	`settings?: models.ISettings;`
	`33`	`+ pageName?: string;`
	`34`	`+ filters?: (models.IBasicFilter \| models.IAdvancedFilter)[];`
`31`	`35`	`}`
`32`	`36`
`33`	`37`	`export interface IInternalEmbedConfiguration extends models.ILoadConfiguration {`