fix aggregate data step missing some entities#1
Open
Meeran-Tofiq wants to merge 1 commit intogunslingerOP:mainfrom
Open
fix aggregate data step missing some entities#1Meeran-Tofiq wants to merge 1 commit intogunslingerOP:mainfrom
Meeran-Tofiq wants to merge 1 commit intogunslingerOP:mainfrom
Conversation
Change 1 (HIGH IMPACT): Harvest tables from ALL files' touches_data File: nodes.py, insert after line 4022 (after the for result in results: loop) Add a new step that collects table references from touches_data of ALL files across ALL components - not just core-kind files. This catches tables from migrations, schemas, configs, etc. Change 2: Better dedup that merges operations File: nodes.py, line 4025 Replace the last-wins dict comprehension with a loop that merges operations and from_component when the same table appears from multiple sources. Change 3: Expand core_kinds and raise limits File: nodes.py - Line 3430: Add migration, schema, config, seed, factory, type, interface, middleware to core_kinds - Line 3443: Raise cap from 25 to 50 - Line 3470: Raise truncation from 30K to 80K chars (or slim down per-file payload to just path/kind/summary/touches_data) Change 4: Make LLM cleanup less aggressive File: nodes.py, in _cleanup_extracted_tables prompt (~line 3584) Add instruction: "When in doubt, KEEP the table. Only filter entries that are clearly NOT data storage identifiers." Change 5 (OPTIONAL): Persist data_structures in SummarizeFiles File: nodes.py, ~line 1867 Currently data_structures is requested from the LLM but silently dropped from the result. Adding it would enable downstream nodes to use it. Requires re-running SummarizeFiles for existing projects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change 1 (HIGH IMPACT): Harvest tables from ALL files' touches_data
File: nodes.py, insert after line 4022 (after the for result in results: loop)
Add a new step that collects table references from touches_data of ALL files across ALL components - not just core-kind files. This catches tables from migrations,
schemas, configs, etc.
Change 2: Better dedup that merges operations
File: nodes.py, line 4025
Replace the last-wins dict comprehension with a loop that merges operations and from_component when the same table appears from multiple sources.
Change 3: Expand core_kinds and raise limits
File: nodes.py
Change 4: Make LLM cleanup less aggressive
File: nodes.py, in _cleanup_extracted_tables prompt (~line 3584)
Add instruction: "When in doubt, KEEP the table. Only filter entries that are clearly NOT data storage identifiers."
Change 5 (OPTIONAL): Persist data_structures in SummarizeFiles
File: nodes.py, ~line 1867
Currently data_structures is requested from the LLM but silently dropped from the result. Adding it would enable downstream nodes to use it. Requires re-running
SummarizeFiles for existing projects.