Skip to content

Commit aae9fa7

Browse files
committed
Bump python-rsa dependency range
PythonRSA 4.3 and 4.5 are the same release, they are also the same as 4.0 with some bugfix backports. Python 2 support was removed in 4.1, but since 4.3/4.5 are just a re-released 4.0, they support python 2.7. So the version range <=4.5 supports python 2.7 and python 3. However; Python 3.4 support was also removed in 4.1, and is explicitly called out as not restored in 4.3/4.5. Which means we need to branch our dependency on rsa for Python 3.4 to include 4.0, which is the last version to have Python 3.4 support. rsa 4.0 is also explicitlly pulled into the bundled installer.
1 parent 5c65412 commit aae9fa7

3 files changed

Lines changed: 5 additions & 2 deletions

File tree

scripts/make-bundle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ EXTRA_RUNTIME_DEPS = [
2828
('colorama', '0.4.1'),
2929
('urllib3', '1.25.7'),
3030
('PyYAML', '5.2'),
31+
('rsa', '4.0'),
3132
]
3233
BUILDTIME_DEPS = [
3334
('setuptools-scm', '3.3.3'),

setup.cfg

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,13 @@ universal = 1
66
requires-dist =
77
botocore==1.17.18
88
docutils>=0.10,<0.16
9-
rsa>=3.1.2,<=3.5.0
109
s3transfer>=0.3.0,<0.4.0
1110
PyYAML>=3.10,<5.3; python_version=='3.4'
1211
PyYAML>=3.10,<5.4; python_version!='3.4'
1312
colorama>=0.2.5,<0.4.2; python_version=='3.4'
1413
colorama>=0.2.5,<0.4.4; python_version!='3.4'
14+
rsa>=3.1.2,<=4.0.0; python_version=='3.4'
15+
rsa>=3.1.2,<=4.5.0; python_version!='3.4'
1516

1617

1718
[check-manifest]

setup.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,17 +26,18 @@ def find_version(*file_paths):
2626
install_requires = [
2727
'botocore==1.17.18',
2828
'docutils>=0.10,<0.16',
29-
'rsa>=3.1.2,<=3.5.0',
3029
's3transfer>=0.3.0,<0.4.0',
3130
]
3231

3332

3433
if sys.version_info[:2] == (3, 4):
3534
install_requires.append('PyYAML>=3.10,<5.3')
3635
install_requires.append('colorama>=0.2.5,<0.4.2')
36+
install_requires.append('rsa>=3.1.2,<=4.0.0')
3737
else:
3838
install_requires.append('PyYAML>=3.10,<5.4')
3939
install_requires.append('colorama>=0.2.5,<0.4.4')
40+
install_requires.append('rsa>=3.1.2,<=4.5.0')
4041

4142

4243
setup_options = dict(

0 commit comments

Comments
 (0)