look into dock name issue, find that it is a Java bug...

benfry · benfry · commit 9ed6dee84eca · 2017-05-04T11:59:38.000-04:00
diff --git a/core/src/processing/core/PApplet.java b/core/src/processing/core/PApplet.java
@@ -10459,6 +10459,9 @@ static public void runSketch(final String[] args,
     // Remove 60fps limit on the JavaFX "pulse" timer
     System.setProperty("javafx.animation.fullspeed", "true");
 
+    // Doesn't seem to do anything helpful here (that can't be done via Runner)
+    //System.setProperty("com.apple.mrj.application.apple.menu.about.name", "potato");
+
     Thread.setDefaultUncaughtExceptionHandler(new Thread.UncaughtExceptionHandler() {
       public void uncaughtException(Thread t, Throwable e) {
         e.printStackTrace();
diff --git a/core/todo.txt b/core/todo.txt
@@ -1,10 +1,5 @@
 0261 (3.3.4 or 3.4)
 
-_ set the application name to sketch name (not processing.core.PApplet)
-_   System.setProperty("com.apple.mrj.application.apple.menu.about.name", ...)
-_   -Xdock:name=<application name>
-_   -Xdock:icon=<path to icon file>
-
 _ WARNING: GL pipe is running in software mode (Renderer ID=0x1020400)
 _   is this coming from us? if so, need to provide actions
 
diff --git a/java/src/processing/mode/java/runner/Runner.java b/java/src/processing/mode/java/runner/Runner.java
@@ -341,9 +341,12 @@ protected StringList getMachineParams() {
     }
 
     if (Platform.isMacOS()) {
+      // This successfully sets the application menu name,
+      // but somehow, not the dock name itself.
       params.append("-Xdock:name=" + build.getSketchClassName());
-//      params.add("-Dcom.apple.mrj.application.apple.menu.about.name=" +
-//                 sketch.getMainClassName());
+      // No longer needed / doesn't seem to do anything differently
+      //params.append("-Dcom.apple.mrj.application.apple.menu.about.name=" +
+      //              build.getSketchClassName());
     }
     // sketch.libraryPath might be ""
     // librariesClassPath will always have sep char prepended
diff --git a/todo.txt b/todo.txt
@@ -19,6 +19,11 @@ X   https://github.com/processing/processing/pull/5044
 _ should ant run launch the .app so that launchsvcs stuff works properly?
 
 _ sketch.properties not being written if initial mode is p5.js?
+_ when creating a sketch within non-Java mode, should write the settings file
+_   so that it re-loads in the proper environment
+_ remove sketch.properties when moving back to the default?
+_   or can we not do this, because it's used to set the 'next' mode
+
 _ what to double-click when opening p5 projects
 _   lack of a project file makes this a pain
 _   dropping a sketch folder onto the PDE should also be implemented
@@ -31,6 +36,9 @@ _     https://github.com/processing/processing/issues/3987
 _   also see several notes below re: examples
 _ how are file associations handled in Linux? (for .pde, .psk)
 
+_ add means to import .zip files from file/url into sketchbook, library, etc.
+_   super easy given current code implementation, might help usability
+
 _ EventQueue problems with "could not find sketch size" message
 _   https://github.com/processing/processing/issues/4893
 _   https://github.com/processing/processing/issues/5030
@@ -40,20 +48,13 @@ _   unzipping the app takes forever
 _   see the 'examples' section below
 
 _ untitled folders are stored in temp folder
-
 _ clean up /tmp folders used during build
 _   https://github.com/processing/processing/issues/1896
 _ don't let people into the /tmp folder for sketches
 o   don't use tmp folder for sketches? 
 _   restrict more things like "show sketch folder"
 _   don't allow adding files w/o saving
 _   others?
-_ when creating a sketch within non-Java mode, should write the settings file
-_   so that it re-loads in the proper environment
-_ remove sketch.properties when moving back to the default?
-_   or can we not do this, because it's used to set the 'next' mode
-_ add means to import .zip files from file/url into sketchbook, library, etc.
-_   super easy given current code implementation, might help usability
 
 
 contrib
@@ -944,6 +945,8 @@ _   this may already work with SingleInstance stuff
 
 DIST / Mac OS X
 
+_ Java bug prevents us from setting the dock name of a sketch run from the PDE
+_   https://github.com/processing/processing/issues/5045
 _ client properties 
 _   https://developer.apple.com/library/mac/technotes/tn2007/tn2196.html
 _ built-in images: http://nadeausoftware.com/articles/2008/12/mac_java_tip_how_access_mac_specific_nsimage_icons

Original file line number	Diff line number	Diff line change
`@@ -341,9 +341,12 @@ protected StringList getMachineParams() {`
`341`	`341`	`}`
`342`	`342`
`343`	`343`	`if (Platform.isMacOS()) {`
	`344`	`+ // This successfully sets the application menu name,`
	`345`	`+ // but somehow, not the dock name itself.`
`344`	`346`	`params.append("-Xdock:name=" + build.getSketchClassName());`
`345`		`-// params.add("-Dcom.apple.mrj.application.apple.menu.about.name=" +`
`346`		`-// sketch.getMainClassName());`
	`347`	`+ // No longer needed / doesn't seem to do anything differently`
	`348`	`+ //params.append("-Dcom.apple.mrj.application.apple.menu.about.name=" +`
	`349`	`+ // build.getSketchClassName());`
`347`	`350`	`}`
`348`	`351`	`// sketch.libraryPath might be ""`
`349`	`352`	`// librariesClassPath will always have sep char prepended`