Skip to content

Text selection overlay entry point#569

Draft
softmarshmallow wants to merge 1 commit intomainfrom
chore/text-selection-overlay-entry-point-480b
Draft

Text selection overlay entry point#569
softmarshmallow wants to merge 1 commit intomainfrom
chore/text-selection-overlay-entry-point-480b

Conversation

@softmarshmallow
Copy link
Member

Add TextSelectionOverlay to manage text node selection, centralizing text-specific overlay logic and ensuring proper rendering when editing text in WASM.

When editing text with the WASM backend, the DOM overlay was redundant and could cause visual discrepancies with the WASM-rendered outline. This change introduces a dedicated overlay component for text nodes that hides the DOM frame in such cases, ensuring only the WASM outline is visible and in sync.


Open in Web Open in Cursor 

- Add dedicated TextSelectionOverlay (single selection only)
- Hide DOM overlay when WASM backend + text edit mode (WASM highlight only)
- Branch SingleSelectionOverlay on tspan to use TextSelectionOverlay
- Keeps text overlay logic trackable in one entry point

Co-authored-by: universe <[email protected]>
@cursor
Copy link

cursor bot commented Mar 10, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@vercel
Copy link

vercel bot commented Mar 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Mar 10, 2026 0:04am
grida Ready Ready Preview, Comment Mar 10, 2026 0:04am
5 Skipped Deployments
Project Deployment Actions Updated (UTC)
code Ignored Ignored Mar 10, 2026 0:04am
legacy Ignored Ignored Mar 10, 2026 0:04am
backgrounds Skipped Skipped Mar 10, 2026 0:04am
blog Skipped Skipped Mar 10, 2026 0:04am
viewer Skipped Skipped Mar 10, 2026 0:04am

Request Review

@coderabbitai
Copy link

coderabbitai bot commented Mar 10, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4a3b5748-6914-480b-92e9-f859043113a9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/text-selection-overlay-entry-point-480b

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants