tls_wrap: fix BIO leak on SSL error

indutny · indutny · commit e74b5d278ca9 · 2015-03-25T17:50:50.000-05:00
Fix: nodejs#1075 PR-URL: nodejs#1244 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
diff --git a/src/tls_wrap.cc b/src/tls_wrap.cc
@@ -374,7 +374,7 @@ Local<Value> TLSWrap::GetSSLError(int status, int* err, const char** msg) {
           buf[mem->length] = '\0';
           *msg = buf;
         }
-        static_cast<void>(BIO_reset(bio));
+        BIO_free_all(bio);
 
         return scope.Escape(exception);
       }

Original file line number	Diff line number	Diff line change
`@@ -374,7 +374,7 @@ Local<Value> TLSWrap::GetSSLError(int status, int* err, const char** msg) {`
`374`	`374`	`buf[mem->length] = '\0';`
`375`	`375`	`*msg = buf;`
`376`	`376`	`}`
`377`		`- static_cast<void>(BIO_reset(bio));`
	`377`	`+ BIO_free_all(bio);`
`378`	`378`
`379`	`379`	`return scope.Escape(exception);`
`380`	`380`	`}`