Add: Credential stores support #1274
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Scanning the following files:
Scan: 'gvm/protocols/gmp/_gmpnext.py'Nothing detected in gvm/protocols/gmp/_gmpnext.py Scan: 'gvm/protocols/gmp/requests/next/init.py'Nothing detected in gvm/protocols/gmp/requests/next/init.py Scan: 'gvm/protocols/gmp/requests/next/_credential_stores.py'Nothing detected in gvm/protocols/gmp/requests/next/_credential_stores.py Scan: 'gvm/protocols/gmp/requests/next/_credentials.py'Nothing detected in gvm/protocols/gmp/requests/next/_credentials.py Scan: 'tests/protocols/gmpnext/entities/credential_stores/init.py'Nothing detected in tests/protocols/gmpnext/entities/credential_stores/init.py Scan: 'tests/protocols/gmpnext/entities/credential_stores/test_get_credential_stores.py'Nothing detected in tests/protocols/gmpnext/entities/credential_stores/test_get_credential_stores.py Scan: 'tests/protocols/gmpnext/entities/credential_stores/test_modify_credential_stores.py'Nothing detected in tests/protocols/gmpnext/entities/credential_stores/test_modify_credential_stores.py Scan: 'tests/protocols/gmpnext/entities/credential_stores/test_verify_credential_stores.py'Nothing detected in tests/protocols/gmpnext/entities/credential_stores/test_verify_credential_stores.py Scan: 'tests/protocols/gmpnext/entities/credentials/init.py'Nothing detected in tests/protocols/gmpnext/entities/credentials/init.py Scan: 'tests/protocols/gmpnext/entities/credentials/test_create_credential_store_credential.py'Nothing detected in tests/protocols/gmpnext/entities/credentials/test_create_credential_store_credential.py Scan: 'tests/protocols/gmpnext/entities/credentials/test_modify_credential_store_credential.py'Nothing detected in tests/protocols/gmpnext/entities/credentials/test_modify_credential_store_credential.py Scan: 'tests/protocols/gmpnext/entities/test_credential_stores.py'Nothing detected in tests/protocols/gmpnext/entities/test_credential_stores.py Scan: 'tests/protocols/gmpnext/entities/test_credentials.py'Nothing detected in tests/protocols/gmpnext/entities/test_credentials.py |
Conventional Commits Report
🚀 Conventional commits found. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1274 +/- ##
========================================
Coverage 98.26% 98.27%
========================================
Files 87 89 +2
Lines 6059 6189 +130
Branches 1081 1111 +30
========================================
+ Hits 5954 6082 +128
- Misses 75 76 +1
- Partials 30 31 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bjoernricks
left a comment
bjoernricks
left a comment
There was a problem hiding this comment.
Could you please add tests too?
There was a problem hiding this comment.
Maybe we should split credential and credential store? Having a dedicated type enum for both and separated methods. CredentialStoreType and create_credential_store_credential or similar? For me create_credential has to many arguments. Same for modify_credential.
Pull request was converted to draft
tests/protocols/gmpnext/entities/credentials/test_create_credential_store_credential.py
Outdated
Show resolved
Hide resolved
tests/protocols/gmpnext/entities/credentials/test_modify_credential_store_credential.py
Outdated
Show resolved
Hide resolved
bjoernricks
left a comment
bjoernricks
left a comment
There was a problem hiding this comment.
I am not 100 percent sure about the details. Could you check other methods how we handle them for the single get use case?
What
Add support for credential stores
Why
Support new feature in python-gvm
References
GEA-1261