Remove incorrect @Nullable from GraphQLSchema.getCodeRegistry()#4247
Merged
Remove incorrect @Nullable from GraphQLSchema.getCodeRegistry()#4247
Conversation
The codeRegistry field was annotated @nullable and the first-pass constructor set it to null, even though it asserted the builder value was non-null. All three constructors require a non-null codeRegistry, and no fully-constructed schema ever has a null codeRegistry. Fix the first-pass constructor to use the builder's codeRegistry instead of discarding it, and remove @nullable from the field and getter. Co-Authored-By: Claude Opus 4.6 <[email protected]>
andimarek
added this to the
26.x is a breaking change release (other fixes as well) milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@Nullableannotation fromGraphQLSchema.codeRegistryfield andgetCodeRegistry()return typebuilder.codeRegistryinstead of discarding it and setting the field tonullWhy
The field was annotated
@Nullableand the first-pass constructor (private GraphQLSchema(Builder)) setthis.codeRegistry = null— despite assertingbuilder.codeRegistrywas non-null on the line above. All three constructors require a non-null codeRegistry, and no fully-constructed schema ever exposes a null value.The
@Nullableannotation was misleading and caused downstream code to add unnecessary null checks (e.g.schema.getCodeRegistry() != nullguards in validation).Test plan
🤖 Generated with Claude Code