Remove unnecessary uses of _disambiguate_template.#6270
Conversation
Remove the uses of the `_disambiguate_template` pseudo-production from `template_elaborated_ident` and `core_lhs_expression`. These immediately follow an `ident`, which has already triggered template list discovery via its own use of `_disambiguate_template`. Regenerate images and grammar fragments. Fixes gpuweb#6269.
|
Previews, as seen when this build job started (634e15c): |
|
Viewing the generated WGSL preview, it looks like it's still showing, is that expected and something that gets fixed when it's merged?
|
|
Interesting; when I ran bikeshed locally, I got this: 
I did have an earlier version of the branch where I hadn't yet regenerated the fragments. Maybe CI built the HTML from that, and then didn't notice that the PR would affect the HTML, since it only touches included files? |
mehmetoguzderin
left a comment
mehmetoguzderin
left a comment
There was a problem hiding this comment.
Basically LGTM in terms of syntax, the preview render issue is related to CI picking files individually (probably). Additional review would be also appreciated
dneto0
left a comment
dneto0
left a comment
There was a problem hiding this comment.
LGTM. Thanks for your diligence.
(Can't verify in the moment but if this breaks anything/anybody we can reverse if we need to.)
4 participants
Remove the uses of the
_disambiguate_templatepseudo-production fromtemplate_elaborated_identandcore_lhs_expression. These immediately follow anident, which has already triggered template list discovery via its own use of_disambiguate_template.Regenerate images and grammar fragments.
Fixes #6269.