Fix attribute validation#4998
Merged
Merged
Conversation
kainino0x
added
copyediting
Contributor
|
Previews, as seen when this build job started (457c0ac): |
toji
approved these changes
Nov 26, 2024
toji
left a comment
toji
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for the nice cleanup!
kainino0x
added a commit
to kainino0x/gpuweb
that referenced
this pull request
Nov 26, 2024
kainino0x
added a commit
that referenced
this pull request
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suggest reviewing commits separately
Note the previous (nonsensical) validation required each shader attribute to have one
GPUVertexAttributematching BOTH its location and type. The new validation requires each shader attribute to have oneGPUVertexAttributematching its location, then that attribute must match in type. This should be the same because we also had validation that said eachshaderLocationin the pipeline was unique.Fixes #4994