Add watermark for pdfengine #1379
Conversation
maximemenager
force-pushed
the
FEAT-add-watermark-route
branch
from
eb4aa37 to
d9d8355
Compare
gulien
left a comment
gulien
left a comment
There was a problem hiding this comment.
Thank you very much for this PR!
Your current implementation is very linked to pdfcpu.
Other PDF engines may have a different implementation.
As a rule of thumb, new features related to PDF engines should have the correct abstraction so that implementations details do not leak in the API.
I think we should have a notion of stamp (in front of content) vs watermark (in the background).
Maybe two different routes?
When a new PDF engine functionality is added, it's also provided in the following endpoints:
/forms/chromium/convert/html/forms/chromium/convert/url/forms/chromium/convert/markdown/forms/libreoffice/convert/forms/pdfengines/merge/forms/pdfengines/split
Don't forget to add the new flag pdfengines-watermark-engines in the Makefile.
Use a tag @watermark to tag your tests (see #1380).
pkg/gotenberg/pdfengine.go
Outdated
| // AddWatermark adds a watermark to a PDF file. | ||
| // The mode can be "text", "image", or "pdf". | ||
| // The watermark is either text content or a file path depending on the mode. | ||
| AddWatermark(ctx context.Context, logger *zap.Logger, mode, watermark, inputPath, description string) error |
There was a problem hiding this comment.
| AddWatermark(ctx context.Context, logger *zap.Logger, mode, watermark, inputPath, description string) error | |
| Watermark(ctx context.Context, logger *zap.Logger, mode, watermark, inputPath, description string) error |
pkg/modules/pdfengines/routes.go
Outdated
| func watermarkRoute(engine gotenberg.PdfEngine) api.Route { | ||
| return api.Route{ | ||
| Method: http.MethodPost, | ||
| Path: "/forms/pdfengines/add-watermark", |
There was a problem hiding this comment.
| Path: "/forms/pdfengines/add-watermark", | |
| Path: "/forms/pdfengines/watermark", |
pkg/modules/pdfengines/routes.go
Outdated
| var inputPaths []string | ||
| var watermarkPath string | ||
| var watermarkFilename string | ||
| var watermarkText string | ||
| var watermarkMode string | ||
| var params string |
There was a problem hiding this comment.
| var inputPaths []string | |
| var watermarkPath string | |
| var watermarkFilename string | |
| var watermarkText string | |
| var watermarkMode string | |
| var params string | |
| var ( | |
| inputPaths []string | |
| watermarkPath string | |
| watermarkFilename string | |
| watermarkText string | |
| watermarkMode string | |
| ) |
tahaOABA
force-pushed
the
FEAT-add-watermark-route
branch
from
4bd2939 to
58bbe64
Compare
3 participants
This pull request introduces document watermarking feature using the
pdfcpulibrary, enabling flexible watermark generation for PDF documents.Implementation Notes: