Skip to content

Bump up Editors quickstarts to Java 8#83

Merged
asrivas merged 1 commit into
masterfrom
editors8
Aug 19, 2019
Merged

Bump up Editors quickstarts to Java 8#83
asrivas merged 1 commit into
masterfrom
editors8

Conversation

@asrivas

@asrivas asrivas commented Aug 12, 2019

Copy link
Copy Markdown
Contributor

- Ran Intellij Java8 inspection over files
- After all quickstarts are updated, move up required version:
https://developers.google.com/docs/api/quickstart/java
@asrivas asrivas requested a review from sqrrrl August 12, 2019 03:48
@erickoledadevrel

Copy link
Copy Markdown

Is there any code in these quickstarts that's not Java 8 idiomatic? Like should we be taking advantage of some new Java 8 syntax?

@asrivas

asrivas commented Aug 12, 2019

Copy link
Copy Markdown
Contributor Author

I was really hoping to find SOMETHING so I set this up:
https://blog.jetbrains.com/idea/2016/12/intellij-idea-inspection-settings-for-refactoring-to-java-8/
I was super surprised nothing got flagged, maybe I did it wrong?

@sqrrrl

sqrrrl commented Aug 14, 2019

Copy link
Copy Markdown
Member

There's nothing in the quickstarts that's made better by Java 8 syntax or APIs.

@asrivas asrivas merged commit f56ef37 into master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants