feat: add logic to convert severity string to uppercase #744
feat: add logic to convert severity string to uppercase #744daniel-sanche merged 7 commits intogoogleapis:mainfrom
Conversation
|
the reason why I skipped |
|
This looks great! Would you mind adding a test for this too though, since the bug must have slipped through with the existing tests? |
|
@daniel-sanche I added a small unit test to check if |
|
You can ignore the environment test failures. It looks like I need to upgrade the pandas version there, I'll address that in a separate PR It looks like there's a lint issue on the Kokoro check before this can be merged though |
|
I just ran I hope this fix works. |
|
looks great, thanks! |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #743