Skip to content

fix: avoid live music API key in websocket URL#2449

Open
MukundaKatta wants to merge 1 commit into
googleapis:mainfrom
MukundaKatta:codex/live-music-websocket-api-key
Open

fix: avoid live music API key in websocket URL#2449
MukundaKatta wants to merge 1 commit into
googleapis:mainfrom
MukundaKatta:codex/live-music-websocket-api-key

Conversation

@MukundaKatta

@MukundaKatta MukundaKatta commented May 15, 2026

Copy link
Copy Markdown
Contributor

Fixes #2398.

Summary

  • remove the redundant API key query parameter from the live music websocket URL
  • keep authentication via the existing x-goog-api-key header
  • add a regression test that captures the websocket URI and headers

Tests

  • uv run --with pytest --with pytest-asyncio pytest google/genai/tests/live/test_live_music.py -q
  • git diff --check

@MukundaKatta MukundaKatta force-pushed the codex/live-music-websocket-api-key branch from afce59e to 5b8b268 Compare May 15, 2026 20:02
@Venkaiahbabuneelam Venkaiahbabuneelam self-assigned this May 26, 2026
@Venkaiahbabuneelam Venkaiahbabuneelam added the size:L Code changes between 40-100 lines label May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Venkaiahbabuneelam Venkaiahbabuneelam

Labels

size:L Code changes between 40-100 lines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

live_music.py unnecessarily exposes API key in WebSocket URL query parameter (inconsistent with live.py)

2 participants

@MukundaKatta @Venkaiahbabuneelam