fix: Fixed exception when the python executable path has a space in it#267
Merged
ivanmkc merged 1 commit intoMar 22, 2021
Conversation
google-cla
Bot
added
the
cla: yes
ivanmkc
commented
Mar 20, 2021
| setup_cmd = self._SETUP_PY_SOURCE_DISTRIBUTION_CMD.format( | ||
| python_executable=_get_python_executable() | ||
| ).split() | ||
| setup_cmd = [ |
Contributor
Author
There was a problem hiding this comment.
Let me know if it's more Pythonic to use append, extend or list comprehension instead.
sasha-gitg
approved these changes
Mar 20, 2021
sasha-gitg
left a comment
sasha-gitg
left a comment
Member
There was a problem hiding this comment.
LGTM. One comment. Thanks!
| setup_cmd = self._SETUP_PY_SOURCE_DISTRIBUTION_CMD.format( | ||
| python_executable=_get_python_executable() | ||
| ).split() | ||
| setup_cmd = [ |
Member
There was a problem hiding this comment.
The key word {python_executable} should be removed in the constant above(line 836) because it looks like it goes unused.
Contributor
Author
There was a problem hiding this comment.
Ah yes, I was testing on a different repo and didn't copy it over.
Contributor
Author
There was a problem hiding this comment.
I fixed it and now addressing some test failures.
ivanmkc
force-pushed
the
imkc--training-job-trainingscript-python-packager-fix
branch
from
b1dbb11 to
19c424d
Compare
ivanmkc
force-pushed
the
imkc--training-job-trainingscript-python-packager-fix
branch
from
19c424d to
693bdb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In lines (line 768-778) in training_jobs.py:
If your python executable path has spaces in it, you get an exception:
FileNotFoundError: [Errno 2] No such file or directory: '/Volumes/GoogleDrive/Shared'which is the part of your executable path before the first space.
This fixes avoids combining the executable and args together, which fixes the problem.