feat: Added encryption_spec_key_name to all relevant resources#256
Merged
Conversation
ivanmkc
changed the title
google-cla
Bot
added
the
cla: yes
ivanmkc
commented
Mar 3, 2021
ivanmkc
force-pushed
the
imkc--cmek-support2
branch
from
c0efeb7 to
7729595
Compare
…TrainingJob, CustomPythonPackageTrainingJob, CustomContainerTrainingJob, CustomTrainingJob, AutoMLTabularTrainingJob, AutoMLImageTrainingJob, AutoMLTextTrainingJob
ivanmkc
force-pushed
the
imkc--cmek-support2
branch
from
cd16b6f to
7646caf
Compare
ivanmkc
changed the title
Contributor
Author
|
I've modified existing tests to handle CMEK for the cases where it's passed into aiplatform.init and where it's passed into the job itself. Let me know if any of that is weird or could be improved. |
ivanmkc
commented
Mar 8, 2021
ivanmkc
changed the title
sasha-gitg
requested changes
Mar 9, 2021
| credentials (auth_credentials.Credentials): | ||
| Custom credentials to use to run call training service. Overrides | ||
| credentials set in aiplatform.init. | ||
| training_pipeline_encryption_spec_key_name (Optional[str]): |
Member
There was a problem hiding this comment.
I'd possibly remove pipeline from this name so it's consistent with the class name. If we end up changing this the XTrainingPipeline instead of XTrainignJob, we can add it back. You can leave the docstring as is.
sasha-gitg
requested changes
Mar 10, 2021
ivanmkc
force-pushed
the
imkc--cmek-support2
branch
from
267feeb to
25c3ef4
Compare
Contributor
Author
|
@sasha-gitg Fixed according to comments and then improved some docstrings. |
sasha-gitg
approved these changes
Mar 11, 2021
| self, encryption_spec_key_name: Optional[str] | ||
| ) -> Optional[gca_encryption_spec.EncryptionSpec]: | ||
| """Creates a gca_encryption_spec.EncryptionSpec instance from the given key name. | ||
| If the provided key name is None, it uses the default key name if provided. |
Member
There was a problem hiding this comment.
Needs Args and Returns section.
Contributor
Author
There was a problem hiding this comment.
I need to improve my docstring game. Thanks
vinnysenthil
approved these changes
Mar 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The encryption key can be passed into aiplatform.init which will be applied to all applicable resources:
Alternatively, it can be passed directly into the resource itself on creation. This will override the aiplatform default.
Currently Unused:
Fixes b/178500930