Skip to content

chore: sample tests decouple#124

Merged
dizcology merged 6 commits into
googleapis:masterfrom
dizcology:sample_tests_decouple
Dec 8, 2020
Merged

chore: sample tests decouple#124
dizcology merged 6 commits into
googleapis:masterfrom
dizcology:sample_tests_decouple

Conversation

@dizcology

@dizcology dizcology commented Dec 7, 2020

Copy link
Copy Markdown
Contributor

Refactor sample tests.

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 7, 2020
@dizcology dizcology changed the title chore: move shared fixtures into conftest.py chore: sample tests decouple Dec 7, 2020
@dizcology dizcology marked this pull request as ready for review December 8, 2020 05:54
@dizcology dizcology requested a review from a team as a code owner December 8, 2020 05:54
@dizcology dizcology requested review from engelke and removed request for a team December 8, 2020 05:54
engelke
engelke approved these changes Dec 8, 2020
View reviewed changes

@engelke engelke left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dizcology dizcology merged commit 6096ce7 into googleapis:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@engelke engelke engelke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dizcology @engelke