Skip to content

docs(samples): add AutoML image classification sample #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rosiezou merged 22 commits into from
Aug 9, 2022
Merged

docs(samples): add AutoML image classification sample #923

rosiezou merged 22 commits into from
Aug 9, 2022
+87 −0

Conversation

@andrewferlitsch
Copy link
Contributor

@andrewferlitsch andrewferlitsch commented Dec 21, 2021 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #202042079🦕

@andrewferlitsch andrewferlitsch requested review from a team as code owners December 21, 2021 19:45
@snippet-bot
Copy link

snippet-bot bot commented Dec 21, 2021 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@andrewferlitsch
Copy link
Contributor Author

andrewferlitsch commented Dec 21, 2021

The build is failing:

import tensorflow as tf
E ModuleNotFoundError: No module named 'tensorflow'

That seems to be part of the testing pipeline, so not sure how to fix.

@morgandu morgandu self-requested a review January 5, 2022 20:19
morgandu
morgandu suggested changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@morgandu morgandu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the PR title from "fix: ..." to "samples: ...".

"fix: ..." and "feat: ..." are reserved for Vertex SDK and the title content will be propagated to the Release Note.

@kweinmeister
Copy link
Contributor

kweinmeister commented Jan 10, 2022

Also, to add to @morgandu's comment, it's preferred if we don't refer to internal bug numbers that some users may not have access to.

So, could the title also be changed to include a summary of what was actually fixed? That will make the Release Notes for this fix more useful.

kweinmeister
kweinmeister reviewed Mar 17, 2022
View reviewed changes
samples/model-builder/predict_image_classification_sample.py Outdated


# [START aiplatform_sdk_predict_image_classification_sample]
def predict_tabular_classification_sample(
Copy link
Contributor

@kweinmeister kweinmeister Mar 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this read predict_image_classification_sample?

Copy link
Contributor Author

@andrewferlitsch andrewferlitsch Mar 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that looks like a typo.

Copy link
Contributor Author

@andrewferlitsch andrewferlitsch Mar 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it.

@kweinmeister kweinmeister changed the title fix: issue 202042079 samples: add AutoML image classification sample Mar 17, 2022
@kweinmeister kweinmeister changed the title samples: add AutoML image classification sample docs(samples): add AutoML image classification sample Mar 17, 2022
@kweinmeister kweinmeister added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 17, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 17, 2022
@morgandu morgandu self-requested a review March 18, 2022 00:27
@morgandu morgandu added the automerge Merge the pull request once unit tests and other checks pass. label Mar 18, 2022
@sasha-gitg sasha-gitg removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 21, 2022
@product-auto-label product-auto-label bot added api: vertex-ai Issues related to the googleapis/python-aiplatform API. samples Issues that are directly related to samples. labels May 5, 2022
@sararob sararob added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 5, 2022
@sasha-gitg sasha-gitg added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jun 9, 2022
@sasha-gitg sasha-gitg added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jun 29, 2022
@andrewferlitsch andrewferlitsch requested a review from a team as a code owner July 1, 2022 14:08
@sararob sararob added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jul 15, 2022
@nayaknishant nayaknishant added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 27, 2022
@jaycee-li jaycee-li removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 27, 2022
@rosiezou rosiezou self-assigned this Aug 2, 2022
@nayaknishant nayaknishant added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 4, 2022
@rosiezou rosiezou removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 4, 2022
@rosiezou rosiezou merged commit 677b311 into main Aug 9, 2022
@rosiezou rosiezou deleted the issue_202042079 branch August 9, 2022 20:56
@release-please release-please bot mentioned this pull request Aug 9, 2022
Merged
@release-please release-please bot mentioned this pull request Jun 8, 2023
Closed
@release-please release-please bot mentioned this pull request Aug 25, 2023
Closed
@release-please release-please bot mentioned this pull request Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kweinmeister kweinmeister kweinmeister approved these changes

@nicain nicain Awaiting requested review from nicain nicain was automatically assigned from googleapis/python-samples-owners

+1 more reviewer

@morgandu morgandu morgandu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rosiezou rosiezou

Labels

api: vertex-ai Issues related to the googleapis/python-aiplatform API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@andrewferlitsch @kweinmeister @morgandu @sararob @rosiezou @nayaknishant @sasha-gitg @yoshi-kokoro @jaycee-li