Skip to content

Conversation

@SinaChavoshi
Copy link
Member

@SinaChavoshi SinaChavoshi commented Jul 22, 2022

BEGIN_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat:Refactor schema classes to subclass from _Resource
This release feature changes the internal implementation of create method in Schema classes. The methods Artifact.create_from_base_artifact_schema and Execution.create_from_base_execution_schema that were previously used by Schema classes are removed and the schema_base classes are now directly inheriting from the corresponding Artifact and Execution class.
END_COMMIT_OVERRIDE

feat:Refactor schema classes to subclass from _Resource
END_COMMIT_OVERRIDE

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@SinaChavoshi SinaChavoshi requested a review from a team as a code owner July 22, 2022 06:30
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels Jul 22, 2022
@SinaChavoshi SinaChavoshi requested review from a team as code owners July 22, 2022 18:24
Copy link
Contributor

@jialuzh jialuzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for samples.

@SinaChavoshi SinaChavoshi merged commit 93002e8 into googleapis:main Jul 26, 2022
@parthea parthea added the release-please:force-run To run release-please label Jul 27, 2022
@release-please release-please bot removed the release-please:force-run To run release-please label Jul 27, 2022
jaycee-li added a commit that referenced this pull request Jul 27, 2022
@jaycee-li jaycee-li added the release-please:force-run To run release-please label Jul 27, 2022
@release-please release-please bot removed the release-please:force-run To run release-please label Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants