feat: Vertex AI Experiments GA #1410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xl
sasha-gitg
force-pushed
the
experiments-release
branch
10 times, most recently
from
c0f099d to
4609ebb
Compare
…platform into experiments-release
sasha-gitg
force-pushed
the
experiments-release
branch
2 times, most recently
from
040c59f to
786bd01
Compare
sasha-gitg
force-pushed
the
experiments-release
branch
from
786bd01 to
978ecb4
Compare
sararob
requested changes
Jun 8, 2022
Contributor
sararob
left a comment
sararob
left a comment
There was a problem hiding this comment.
Here's my review of the Artifact class.
samgoodman
suggested changes
Jun 8, 2022
Contributor
samgoodman
left a comment
samgoodman
left a comment
There was a problem hiding this comment.
Small fixes and suggestions, overall LGTM
sasha-gitg
added
the
do not merge
sararob
requested changes
Jun 9, 2022
Contributor
sararob
left a comment
sararob
left a comment
There was a problem hiding this comment.
Review of Context, Execution, Experiment Resources, and some tests.
sasha-gitg
removed
the
do not merge
jialuzh
reviewed
Jun 9, 2022
|
|
||
| class _VertexResourceArtifactResolver: | ||
|
|
||
| _resource_to_artifact_type = {models.Model: "google.VertexModel"} |
Contributor
There was a problem hiding this comment.
IIUC, this resolver would automatically link a resource to a MLMD artifact? And if so, is Model the only one we would support for GA? How about managed dataset?
Member
Author
There was a problem hiding this comment.
I opened a ticket and added TODO for managed dataset. Let me sync with the service team to see if we can get this in before GA.
sararob
requested changes
Jun 9, 2022
|
|
||
| @staticmethod | ||
| def _get_experiment( | ||
| experiment: Optional[Union[experiment_resources.Experiment, str]] = None, |
Contributor
There was a problem hiding this comment.
Flagging since in the docstring this is called experiment_name and is required.
sararob
requested changes
Jun 10, 2022
Contributor
sararob
left a comment
sararob
left a comment
There was a problem hiding this comment.
My last batch of review, great job!
|
|
||
| from google.cloud.aiplatform import initializer | ||
| from google.cloud.aiplatform.metadata.metadata import metadata_service | ||
| from google.cloud.aiplatform.metadata.metadata import _experiment_tracker |
Contributor
There was a problem hiding this comment.
Here's the error when I try to run test_initializer:
__________________________________________________________________________________________________________ ERROR collecting tests/unit/aiplatform/test_initializer.py __________________________________________________________________________________________________________
ImportError while importing test module '/Users/sararob/Dev/sara-fork/python-aiplatform/tests/unit/aiplatform/test_initializer.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/importlib/__init__.py:127: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
tests/unit/aiplatform/test_initializer.py:28: in <module>
from google.cloud.aiplatform.metadata.metadata import _experiment_tracker
E ImportError: cannot import name '_experiment_tracker' from 'google.cloud.aiplatform.metadata.metadata' (/Users/sararob/Library/Python/3.8/lib/python/site-packages/google/cloud/aiplatform/metadata/metadata.py)
samgoodman
approved these changes
Jun 10, 2022
sasha-gitg
force-pushed
the
experiments-release
branch
from
8c5cde5 to
58e426f
Compare
sararob
approved these changes
Jun 13, 2022
dizcology
approved these changes
Jun 13, 2022
jialuzh
approved these changes
Jun 13, 2022
Ark-kun
reviewed
Jan 11, 2023
| for key, value in metadata.items(): | ||
| # Note: This only support nested dictionaries one level deep | ||
| if isinstance(value, collections.Mapping): | ||
| gca_resource.metadata[key].update(value) |
Contributor
There was a problem hiding this comment.
What is the proposed way to remove keys from a nested dictionary?
P.S. This also seems to fail when the key does not already exist in the metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.