feat(node): add CompatibilityResources option for NodeJS APIs#6238
Draft
jskeet wants to merge 2 commits into
Draft
feat(node): add CompatibilityResources option for NodeJS APIs#6238jskeet wants to merge 2 commits into
jskeet wants to merge 2 commits into
Conversation
If compatibility resources are specified in librarian.yaml, they are passed to the GAPIC generator. Related GAPIC generator option draft PR: googleapis/google-cloud-node#8405
Contributor
Author
|
(Created as a draft so we can consider if this is the right solution for #5040. Still needs names to be agreed, tests etc.) |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new configuration option CompatibilityResources to the Node.js API configuration. This option allows specifying a list of resource names for which legacy single-pattern functions should be generated. The configuration is parsed and passed down to the generator arguments as a semicolon-separated string via the --compatibility-resources flag. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If compatibility resources are specified in librarian.yaml, they are passed to the GAPIC generator.
Related GAPIC generator option draft PR:
googleapis/google-cloud-node#8405