Skip to content

docs: add MySQLVectorStore reference notebook#59

Merged
averikitsch merged 3 commits into
mainfrom
vector-store-docs
Apr 3, 2024
Merged

docs: add MySQLVectorStore reference notebook#59
averikitsch merged 3 commits into
mainfrom
vector-store-docs

Conversation

@jackwotherspoon

@jackwotherspoon jackwotherspoon commented Apr 3, 2024

Copy link
Copy Markdown
Contributor

Adding reference notebook for basic usage of MySQLVectorStore.

Rendered notebook: https://github.com/googleapis/langchain-google-cloud-sql-mysql-python/tree/vector-store-docs/docs/vector_store.ipynb

@jackwotherspoon jackwotherspoon self-assigned this Apr 3, 2024
@jackwotherspoon jackwotherspoon requested a review from a team April 3, 2024 20:58
@product-auto-label product-auto-label Bot added the api: cloudsql-mysql Issues related to the googleapis/langchain-google-cloud-sql-mysql-python API. label Apr 3, 2024
@totoleon

totoleon commented Apr 3, 2024

Copy link
Copy Markdown
Contributor

Tested in colab and it's working fine.

  • For the index operations, we need to manually grant the IAM user permissions
GRANT EXECUTE ON PROCEDURE mysql.create_vector_index TO 'hailongli'@'%';
GRANT EXECUTE ON PROCEDURE mysql.alter_vector_index TO 'hailongli'@'%';
GRANT EXECUTE ON PROCEDURE mysql.drop_vector_index TO 'hailongli'@'%';
GRANT SELECT ON mysql.vector_indexes TO 'hailongli'@'%';
  • nit: do we need to add a cleanup function at the end to drop the test table?

@averikitsch averikitsch merged commit 0ece837 into main Apr 3, 2024
@averikitsch averikitsch deleted the vector-store-docs branch April 3, 2024 23:13
@jackwotherspoon

jackwotherspoon commented Apr 4, 2024

Copy link
Copy Markdown
Contributor Author
  • For the index operations, we need to manually grant the IAM user permissions

@totoleon I'll test today with built-in user and add a note to the index section if need be.

nit: do we need to add a cleanup function at the end to drop the test table?

I don't think we need to cleanup the table, this is just the reference documentation for our APIs and methods. The other vector store langchain integrations do not demonstrate dropping the table/cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudsql-mysql Issues related to the googleapis/langchain-google-cloud-sql-mysql-python API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants