Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

Trying linkage monitor GitHub Actions#822

Closed
suztomo wants to merge 7 commits into
googleapis:masterfrom
suztomo:linkage_monitor_test
Closed

Trying linkage monitor GitHub Actions#822
suztomo wants to merge 7 commits into
googleapis:masterfrom
suztomo:linkage_monitor_test

Conversation

@suztomo

@suztomo suztomo commented Jan 26, 2021

Copy link
Copy Markdown
Member

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@generated-files-bot

generated-files-bot Bot commented Jan 26, 2021

Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 26, 2021
@product-auto-label product-auto-label Bot added the api: spanner Issues related to the googleapis/java-spanner API. label Jan 26, 2021
@codecov

codecov Bot commented Jan 26, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #822 (6dd2f4e) into master (8024980) will decrease coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #822      +/-   ##
============================================
- Coverage     85.03%   84.81%   -0.23%     
+ Complexity     2563     2473      -90     
============================================
  Files           143      143              
  Lines         14062    13779     -283     
  Branches       1348     1227     -121     
============================================
- Hits          11958    11686     -272     
+ Misses         1540     1535       -5     
+ Partials        564      558       -6
Impacted Files Coverage Δ Complexity Δ
...a/com/google/cloud/spanner/DatabaseClientImpl.java 76.69% <0.00%> (-7.77%) 21.00% <0.00%> (ø%)
.../cloud/spanner/spi/v1/SpannerErrorInterceptor.java 52.94% <0.00%> (-7.06%) 3.00% <0.00%> (ø%)
...va/com/google/cloud/spanner/spi/v1/SpannerRpc.java 70.58% <0.00%> (-5.89%) 0.00% <0.00%> (ø%)
...spanner/admin/database/v1/DatabaseAdminClient.java 81.95% <0.00%> (-1.27%) 72.00% <0.00%> (-28.00%)
...in/java/com/google/cloud/spanner/InstanceInfo.java 94.11% <0.00%> (-1.24%) 18.00% <0.00%> (-3.00%)
...ud/spanner/connection/ClientSideStatementImpl.java 47.72% <0.00%> (-1.17%) 9.00% <0.00%> (ø%)
...spanner/admin/instance/v1/InstanceAdminClient.java 78.23% <0.00%> (-0.91%) 42.00% <0.00%> (-14.00%)
...oogle/cloud/spanner/PartitionedDmlTransaction.java 82.02% <0.00%> (-0.59%) 14.00% <0.00%> (-1.00%)
...ain/java/com/google/cloud/spanner/RestoreInfo.java 78.94% <0.00%> (-0.54%) 4.00% <0.00%> (ø%)
...m/google/cloud/spanner/spi/v1/GapicSpannerRpc.java 81.03% <0.00%> (-0.53%) 68.00% <0.00%> (-12.00%)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8024980...6dd2f4e. Read the comment docs.

@suztomo suztomo mentioned this pull request Jan 26, 2021
Closed
@suztomo

suztomo commented Jan 27, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

bf9f427 did not work. The command on the right of "&&" cannot use functions defined in the source.

    - name: Install artifacts to local Maven repository
      run: >
        source .kokoro/common.sh && \
        retry_with_backoff 3 10 \
          mvn install -B -V \
         -DskipTests=true \
         -Dclirr.skip=true \
         -Denforcer.skip=true \
         -Dmaven.javadoc.skip=true \
         -Dgcloud.download.skip=true

37ce68d did not work. The ">" replaces new string with space.

    - name: Install artifacts to local Maven repository
      run: >
        source .kokoro/common.sh \
        retry_with_backoff 3 10 \
          mvn install -B -V \
         -DskipTests=true \

a5bdfca worked

      run: >
        mvn install -B -V \
          -DskipTests=true \
          -Dclirr.skip=true \
          -Denforcer.skip=true \
          -Dmaven.javadoc.skip=true \
          -Dgcloud.download.skip=true

@suztomo

suztomo commented Jan 27, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

e0b27c4 worked.

      run: |
        source .kokoro/common.sh
        retry_with_backoff 3 10 mvn install -B -V -DskipTests=true -Dclirr.skip=true -Denforcer.skip=true -Dmaven.javadoc.skip=true -Dgcloud.download.skip=true

@suztomo

suztomo commented Jan 27, 2021

Copy link
Copy Markdown
Member Author

6dd2f4e works best:

    - name: Install artifacts to local Maven repository
      run: |
        source .kokoro/common.sh
        retry_with_backoff 3 10 \
            mvn install -B -V -Dmaven.test.skip -DskipTests=true \
            -Dclirr.skip=true -Denforcer.skip=true \
            -Dmaven.javadoc.skip=true \
            -Dgcloud.download.skip=true
      shell: bash

@suztomo suztomo closed this Jan 29, 2021
ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request Nov 10, 2022
@codyoss
chore: fix regen (googleapis#822)
30acc4c 
An upcomming change removes some files from tracking. Our current
regen tries to always retain removed files. This is causing issues
in our pipeline so I manually removed the generated surfaces that
are going away in the linked commit:
googleapis/googleapis@7837470
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/java-spanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@suztomo