Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

Add transaction related metrics#1900

Merged
milaGGL merged 57 commits into
mainfrom
mila/client-side-metrics-transaction
Nov 5, 2024
Merged

Add transaction related metrics#1900
milaGGL merged 57 commits into
mainfrom
mila/client-side-metrics-transaction

Conversation

@milaGGL

@milaGGL milaGGL commented Oct 23, 2024

Copy link
Copy Markdown
Contributor
  • add transaction-latency and transaction-attempt-count metrics
  • refactor MetricsContext to use MetricType enum, and add a counter property

@milaGGL milaGGL requested review from a team October 23, 2024 14:22
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: firestore Issues related to the googleapis/java-firestore API. labels Oct 23, 2024
@milaGGL milaGGL changed the title Add transaction related metrics Feat: Add transaction related metrics Oct 23, 2024
@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Oct 28, 2024

@ehsannas ehsannas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! A couple of nits below.

@ehsannas ehsannas assigned milaGGL and unassigned ehsannas Oct 30, 2024
@milaGGL milaGGL requested a review from ehsannas October 31, 2024 15:39
Base automatically changed from mila/client-side-metrics-demo2 to main November 5, 2024 17:49
@milaGGL milaGGL changed the title Feat: Add transaction related metrics Add transaction related metrics Nov 5, 2024
@milaGGL milaGGL merged commit d466ef0 into main Nov 5, 2024
@milaGGL milaGGL deleted the mila/client-side-metrics-transaction branch November 5, 2024 19:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestore Issues related to the googleapis/java-firestore API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants